Skip to content

Nosetests should not be used in travis  #116

Open
@ParthS007

Description

@ParthS007

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/meilix

Actual Behaviour
Presently, Travis run script nosetests app.py while testing which is not needed as nose is used for testing unit tests and moreover nose collects tests from unittest.TestCase subclasses or we can also write simple test functions, as well as test classes that are not subclasses of unittest.TestCase.
But there are no such tests in app.py so the command nosetests app.py is executed with ok status always irrespective of the changes done in the Pull Request.

Expected Behaviour
We should add tests which test functions present in app.py which will be tested in Travis.

Steps to reproduce it

Please see Travis logs for any PR. Like here
image

Would you like to work on the issue?
Yes

@mariobehling @meets2tarun @xeon-zolt Please give your views

Metadata

Metadata

Assignees

No one assigned

    Labels

    GCIGoogle Code-in task

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions