-
-
Notifications
You must be signed in to change notification settings - Fork 118
Open
Labels
won't build!A certain package isn't building, but should.A certain package isn't building, but should.
Description
The package notion-app-electron has a install script named .install, however the build directory is missing this file even though it is in the cloned Git repo which causes the build to fail almost instantly:
~
❯ ls -a ~/.cache/aura/builds/notion-app-electron/
./ ../ notion-app* notion.desktop notion.png PKGBUILD
~
❯ ls -a ~/.cache/aura/packages/notion-app-electron/
./ ../ .git/ .gitignore .install notion-app* notion.desktop notion.png PKGBUILD .SRCINFO
I believe the issue is in build::all_install_files. It uses PathBuf::extension and from the docs, that returns None if the file starts with a leading . and has no other .s. There probably needs to be some other custom logic for detecting install files or we could hardcode the check for files named .install. notion-app-electron isn't the only package I've had issue installing because of this, but it is the most recent one.
Metadata
Metadata
Assignees
Labels
won't build!A certain package isn't building, but should.A certain package isn't building, but should.