target: validate app names in target URIs and skip invalid targets

Ensure the app name declared in target metadata matches the app name
embedded in each app URI when loading plain and TUF repositories.

Changes:

validate URI parsing for each app entry and log detailed errors
verify target app name matches URI app name
use the configured target app name when building App entries
skip the entire target if any app entry is invalid
continue loading other targets from the same targets file

This prevents loading misconfigured targets and avoids relying on
incorrect app names derived from malformed or mismatched URIs.

Signed-off-by: Mike Sul <mike.sul@foundries.io>

Author: mike-sul

pkg/target/plain_repo.go

@@ -104,22 +104,51 @@ func (r *plainRepo) loadTargets(targetsData []byte) error {
 			continue
 		}
 		var apps []App
-		for _, appField := range targetValue.Custom.Apps {
+		isValidTarget := true
+		for appName, appField := range targetValue.Custom.Apps {
 			appRef, err := compose.ParseAppRef(appField.URI)
 			if err != nil {
-				slog.Debug("target with invalid app URI is found", "target custom", targetValue.Custom)
-				continue
+				slog.Error(
+					"failed to parse app URI in target",
+					"target", targetName,
+					"app", appName,
+					"uri", appField.URI,
+					"error", err,
+				)
+				isValidTarget = false
+				// This is an invalid target, continue processing other targets instead of
+				// returning an error since the target file may contain multiple targets and some of them may be valid.
+				break
+			}
+			// The app name embedded in the URI must match the app name declared
+			// in the target configuration. A mismatch indicates a misconfigured
+			// target. This validation is required because composectl derives the
+			// app name from the URI passed through its CLI or API.
+			if appRef.Name != appName {
+				slog.Error(
+					"app name mismatch between target and URI",
+					"target", targetName,
+					"target_app", appName,
+					"uri_app", appRef.Name,
+					"uri", appField.URI,
+				)
+				isValidTarget = false
+				// This is an invalid target, continue processing other targets instead of
+				// returning an error since the target file may contain multiple targets and some of them may be valid.
+				break
 			}
 			apps = append(apps, App{
-				Name: appRef.Name,
+				Name: appName,
 				URI:  appField.URI,
 			})
 		}
-		r.targets = append(r.targets, Target{
-			ID:      targetName,
-			Version: version,
-			Apps:    apps,
-		})
+		if isValidTarget {
+			r.targets = append(r.targets, Target{
+				ID:      targetName,
+				Version: version,
+				Apps:    apps,
+			})
+		}
 	}
 	r.version = targetsFile.Signed.Version
 	return nil

pkg/target/tuf_repo.go

@@ -93,23 +93,51 @@ func (r *tufRepo) loadTargets() error {
 		}
 
 		var apps []App
-		for _, appField := range targetDetails.Apps {
+		isValidTarget := true
+		for appName, appField := range targetDetails.Apps {
 			appRef, err := compose.ParseAppRef(appField.URI)
 			if err != nil {
-				slog.Debug("target with invalid app URI is found", "target custom", targetDetails)
-				continue
+				slog.Error(
+					"failed to parse app URI in target",
+					"target", id,
+					"app", appName,
+					"uri", appField.URI,
+					"error", err,
+				)
+				isValidTarget = false
+				// This is an invalid target, continue processing other targets instead of
+				// returning an error since the target file may contain multiple targets and some of them may be valid.
+				break
+			}
+			// The app name embedded in the URI must match the app name declared
+			// in the target configuration. A mismatch indicates a misconfigured
+			// target. This validation is required because composectl derives the
+			// app name from the URI passed through its CLI or API.
+			if appRef.Name != appName {
+				slog.Error(
+					"app name mismatch between target and URI",
+					"target", id,
+					"target_app", appName,
+					"uri_app", appRef.Name,
+					"uri", appField.URI,
+				)
+				isValidTarget = false
+				// This is an invalid target, continue processing other targets instead of
+				// returning an error since the target file may contain multiple targets and some of them may be valid.
+				break
 			}
 			apps = append(apps, App{
-				Name: appRef.Name,
+				Name: appName,
 				URI:  appField.URI,
 			})
 		}
-
-		r.targets = append(r.targets, Target{
-			ID:      id,
-			Version: version,
-			Apps:    apps,
-		})
+		if isValidTarget {
+			r.targets = append(r.targets, Target{
+				ID:      id,
+				Version: version,
+				Apps:    apps,
+			})
+		}
 	}
 	return nil
 }