Skip to content

Commit af3e41d

Browse files
authored
Merge branch 'master' into grandizzy/fix-release
2 parents 89bd12d + 1c185d1 commit af3e41d

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

crates/evm/core/src/precompiles.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ pub const PRECOMPILES: &[Address] = &[
4949
ODYSSEY_P256_ADDRESS,
5050
];
5151

52-
/// [EIP-7212](https://github.com/ethereum/RIPs/blob/master/RIPS/rip-7212.md) secp256r1 precompile address on Odyssey.
52+
/// [RIP-7212](https://github.com/ethereum/RIPs/blob/master/RIPS/rip-7212.md) secp256r1 precompile address on Odyssey.
5353
///
5454
/// <https://github.com/ithacaxyz/odyssey/blob/482f4547631ae5c64ebea6a4b4ef93184a4abfee/crates/node/src/evm.rs#L35-L35>
5555
pub const ODYSSEY_P256_ADDRESS: Address = address!("0000000000000000000000000000000000000014");
@@ -68,6 +68,6 @@ pub fn p256_verify(input: &Bytes, gas_limit: u64) -> PrecompileResult {
6868
})
6969
}
7070

71-
/// [EIP-7212](https://eips.ethereum.org/EIPS/eip-7212#specification) secp256r1 precompile.
71+
/// [RIP-7212](https://github.com/ethereum/RIPs/blob/master/RIPS/rip-7212.md) secp256r1 precompile.
7272
pub const ODYSSEY_P256: PrecompileWithAddress =
7373
PrecompileWithAddress(ODYSSEY_P256_ADDRESS, Precompile::Standard(p256_verify));

crates/forge/bin/cmd/coverage.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ impl CoverageArgs {
274274

275275
let known_contracts = runner.known_contracts.clone();
276276

277-
let filter = self.test.filter(&config);
277+
let filter = self.test.filter(&config)?;
278278
let outcome = self.test.run_tests(runner, config, verbosity, &filter, output).await?;
279279

280280
outcome.ensure_ok(false)?;

crates/forge/bin/cmd/test/mod.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use super::{install, test::filter::ProjectPathsAwareFilter, watch::WatchArgs};
22
use alloy_primitives::U256;
33
use chrono::Utc;
44
use clap::{Parser, ValueHint};
5-
use eyre::{Context, OptionExt, Result};
5+
use eyre::{bail, Context, OptionExt, Result};
66
use forge::{
77
decode::decode_console_logs,
88
gas_report::GasReport,
@@ -300,7 +300,7 @@ impl TestArgs {
300300
// Set up the project.
301301
let project = config.project()?;
302302

303-
let filter = self.filter(&config);
303+
let filter = self.filter(&config)?;
304304
trace!(target: "forge::test", ?filter, "using filter");
305305

306306
let sources_to_compile = self.get_sources_to_compile(&config, &filter)?;
@@ -815,19 +815,19 @@ impl TestArgs {
815815

816816
/// Returns the flattened [`FilterArgs`] arguments merged with [`Config`].
817817
/// Loads and applies filter from file if only last test run failures performed.
818-
pub fn filter(&self, config: &Config) -> ProjectPathsAwareFilter {
818+
pub fn filter(&self, config: &Config) -> Result<ProjectPathsAwareFilter> {
819819
let mut filter = self.filter.clone();
820820
if self.rerun {
821821
filter.test_pattern = last_run_failures(config);
822822
}
823823
if filter.path_pattern.is_some() {
824824
if self.path.is_some() {
825-
panic!("Can not supply both --match-path and |path|");
825+
bail!("Can not supply both --match-path and |path|");
826826
}
827827
} else {
828828
filter.path_pattern = self.path.clone();
829829
}
830-
filter.merge_with_config(config)
830+
Ok(filter.merge_with_config(config))
831831
}
832832

833833
/// Returns whether `BuildArgs` was configured with `--watch`

crates/forge/bin/cmd/watch.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ pub async fn watch_gas_snapshot(args: GasSnapshotArgs) -> Result<()> {
263263
/// test`
264264
pub async fn watch_test(args: TestArgs) -> Result<()> {
265265
let config: Config = args.build.load_config()?;
266-
let filter = args.filter(&config);
266+
let filter = args.filter(&config)?;
267267
// Marker to check whether to override the command.
268268
let no_reconfigure = filter.args().test_pattern.is_some() ||
269269
filter.args().path_pattern.is_some() ||

0 commit comments

Comments
 (0)