feat: enable decoding non-Ethereum precompiles when tracing #4821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4meta5
changed the title
mattsse
requested changes
Apr 26, 2023
config/src/lib.rs
Outdated
Comment on lines
201
to
203
| /// Information for decoding custom precompile calls | ||
| #[serde(default)] | ||
| pub precompiles: Vec<(Address, Function)>, |
There was a problem hiding this comment.
this is reasonable,
I'd like to see some tests/examples for this in toml format
0xMelkor
reviewed
Apr 26, 2023
Evalir
approved these changes
Aug 16, 2023
|
Will close this—while "complete", it's a pretty sensitive change that will get overwritten by the alloy migration, and on top of this we're still debating a bit on how to include these external precompiles. Once the migration is done we can include a configuration option to detect and decode these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1078
Enable decoding calls from non-Ethereum precompiles when tracing by adding a field to
foundry_config::Configforprecompiles: Vec<(Address, Function)>.Motivation
Enable decoding calls from non Ethereum precompiles when tracing #1078
Solution
Define
with_precompilesmethod onCallTraceDecoderBuilderto augment the Ethereum precompiles included innewmethod with non-Ethereum precompiles specified by a config.