fix cast keccak bug #671
Merged
fix cast keccak bug #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 4, 2022
cast/src/lib.rs
Outdated
Comment on lines
1043
to
1047
| let hash: String = match data.as_bytes() { | ||
| [b'0', b'x', rest @ ..] => keccak256(hex::decode(rest)?).to_hex(), | ||
| _ => keccak256(data).to_hex(), | ||
| }; | ||
|
|
There was a problem hiding this comment.
this is really neat,
can we document this accordingly
If has a 0x prefix, read it as hexdata. Multiple hexstrings can be concatenated with :
If has no 0x prefix, read it as text
There was a problem hiding this comment.
Multiple hexstrings can be concatenated with :
I don't think this functionality is supported on this branch. Do we want to add it on this branch or open an issue and handle in a separate PR?
$ seth keccak 0x1234:0x5678
0x30ca65d5da355227c97ff836c9c6719af9d3835fc6bc72bddc50eeecc1bb2b25
$ seth keccak 0x12345678
0x30ca65d5da355227c97ff836c9c6719af9d3835fc6bc72bddc50eeecc1bb2b25
$ cast keccak 0x1234:0x5678
# errors with "Odd number of digits" which I believe means decoding the hex string failed
$ cast keccak 0x12345678
0x30ca65d5da355227c97ff836c9c6719af9d3835fc6bc72bddc50eeecc1bb2b25
gakonst
approved these changes
Feb 4, 2022
cast/src/lib.rs
Outdated
Comment on lines
1043
to
1047
| let hash: String = match data.as_bytes() { | ||
| [b'0', b'x', rest @ ..] => keccak256(hex::decode(rest)?).to_hex(), | ||
| _ => keccak256(data).to_hex(), | ||
| }; | ||
|
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #669