Skip to content

failed "forge install" should leave workspace untouched. #6790

@drortirosh

Description

@drortirosh

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
    Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

forge 0.2.0 (8343e7d 2024-01-07T00:19:11.564229000Z)

Operating System

macOS (Apple Silicon)

Describe the bug

A failed attempt at forge install (e.g, with broken repo link, like unknown branch) currently leaves the local storage in a "dirty" state, requiring "git reset".
Just like "git" itself, forge should clean up any incomplete work data

Activity

zerosnacks

zerosnacks commented on Jul 9, 2024

@zerosnacks
Member

Can be reproduced by running forge install vectorized/solady@foo (invalid tag). Does not unwind correctly, leaving the .git repo in a dirty state

added this to the v1.0.0 milestone on Jul 26, 2024
removed this from the v1.0.0 milestone on Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-dependenciesArea: dependenciesCmd-forge-pmCommand: forge install/update/removeT-bugType: bug

    Type

    No type

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @grandizzy@drortirosh@zerosnacks

        Issue actions

          failed "forge install" should leave workspace untouched. · Issue #6790 · foundry-rs/foundry