Skip to content

bug(installer): foundryup should only download when updates are available #9519

@gosuto-inzasheru

Description

@gosuto-inzasheru

Component

Foundryup

Have you ensured that all of these are up to date?

  • Foundry
    Foundryup

What version of Foundry are you on?

forge 0.2.0 (00efa0d 2024-12-09T00:29:01.805479000Z)

What command(s) is the bug in?

foundryup

Operating System

macOS (Apple Silicon)

Describe the bug

currently, running foundryup twice in a row will trigger a new download/installation of exactly the same version it installed previously. a lot of resources could be saved by comparing commits, and simply printing something along the lines of "Foundry is already up-to-date (00efa0d 2024-12-09T00:29:01.805479000Z)"

Activity

added and removed
T-needs-triageType: this issue needs to be labelled
on Dec 9, 2024
zerosnacks

zerosnacks commented on Dec 9, 2024

@zerosnacks
Member

cc @grandizzy possibly related to signed releases? we can then just check the local hash against the hash of the binary being pulled in

mgiagante

mgiagante commented on Jan 11, 2025

@mgiagante
Contributor

@zerosnacks I can take this one.

self-assigned this
on Jul 2, 2025
moved this from Todo to In Progress in Foundryon Jul 2, 2025
added this to the v1.3.0 milestone on Jul 2, 2025
moved this from In Progress to Ready For Review in Foundryon Jul 8, 2025
moved this from Ready For Review to Done in Foundryon Jul 10, 2025
gosuto-inzasheru

gosuto-inzasheru commented on Jul 10, 2025

@gosuto-inzasheru
Author

awesome @zerosnacks, looks great! 🙏

moved this from Done to Completed in Foundryon Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Completed

Relationships

None yet

    Participants

    @gosuto-inzasheru@mgiagante@zerosnacks

    Issue actions

      bug(`installer`): `foundryup` should only download when updates are available · Issue #9519 · foundry-rs/foundry