Skip to content

Bug: forge does not add tag information into gitmodules file on install  #7225

@sambacha

Description

@sambacha

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (a436a0d 2024-02-20T00:25:57.253479000Z) && forge 0.2.0 (6d5de51 2024-02-23T00:19:38.512335000Z)

What command(s) is the bug in?

forge install

Operating System

macOS (Apple Silicon)

Describe the bug

Running this install, solidstate-network/[email protected]

$  forge install solidstate-network/[email protected]
Installing solidstate-solidity in /Users/janitor/rico/lib/solidstate-solidity (url: Some("https://github.com/solidstate-network/solidstate-solidity"), tag: Some("v0.0.59"))
Cloning into '/Users/janitor/rico/lib/solidstate-solidity'...
remote: Enumerating objects: 17261, done.
remote: Counting objects: 100% (3206/3206), done.
remote: Compressing objects: 100% (671/671), done.
remote: Total 17261 (delta 2572), reused 3007 (delta 2506), pack-reused 14055
Receiving objects: 100% (17261/17261), 4.06 MiB | 5.31 MiB/s, done.
Resolving deltas: 100% (12427/12427), done.
    Installed solidstate-solidity v0.0.59

After we inspect .gitmodules and find

[submodule "lib/solidstate-solidity"]
        path = lib/solidstate-solidity
        url = https://github.com/solidstate-network/solidstate-solidity

However we want the .gitmodules file to reflect this correct configuration

[submodule "lib/solidstate-solidity"]
        path = lib/solidstate-solidity
        url = https://github.com/solidstate-network/solidstate-solidity
+       branch = v0.0.59

Metadata

Metadata

Assignees

Labels

Cmd-forge-pmCommand: forge install/update/removeP-highPriority: highT-bugType: bug

Type

No type

Projects

Status

Ready For Review

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions