-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(forge) run script install dependencies #9885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(forge) run script install dependencies #9885
Conversation
Hi @programskillforverification thanks for your PR! Instead of moving the |
hey @programskillforverification ! will you be able to push this PR over the finish line? alternatively we can take it over |
I am sorry that I forget this pr. I will finish it asap. |
|
6d5c1e3
to
6cc97a7
Compare
hey @programskillforverification what @zerosnacks suggests is to externalize code from crates/verify/src/install.rs into it's own crate / commons and reuse in both install and verify, does this make sense? @zerosnacks pls chime in in case I I got your comment wrong. thanks |
hey @programskillforverification ! Bump on the previous message, would you be able to take this PR over the finish line, otherwise happy to take over / assign to someone else. just let us know |
I will finish right now |
Hey, @grandizzy, do you means move to crates/common? I once try but can't solve cyclic package dependency |
Motivation
close #9837
Solution
Move
Installer
toforge-verify
, so bothforge
andforge-script
could use it. Keep install argument on original file andforge install
still work.