Fix top call resources (#3426)

Partially solves #3413 (to be verified by someone from snforge team)

## Introduced changes

- stop adding resources used by nested calls to top call recursively -
they already contain cumulative resources

## Checklist

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests - I believe there is a task for that 
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Fiiranek <[email protected]>
Co-authored-by: Franciszek Job <[email protected]>

Author: piotmag769

CHANGELOG.md

@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 #### Fixed
 
 - bug that caused `--trace-verbosity` to panic in fork tests
+- fixed a bug in fork tests where resources used in nested calls were counted multiple times, leading to overestimated gas and resource usage
 
 #### Removed
 

crates/cheatnet/src/runtime_extensions/forge_runtime_extension/mod.rs

@@ -705,7 +705,7 @@ fn add_sierra_gas_resources(top_call: &Rc<RefCell<CallTrace>>) -> u64 {
     let mut gas_consumed = top_call.borrow().gas_consumed;
     for nested_call in &top_call.borrow().nested_calls {
         if let CallTraceNode::EntryPointCall(nested_call) = nested_call {
-            gas_consumed += &add_sierra_gas_resources(nested_call);
+            gas_consumed += &nested_call.borrow().gas_consumed;
         }
     }
     gas_consumed
@@ -717,7 +717,7 @@ fn add_execution_resources(top_call: Rc<RefCell<CallTrace>>) -> ExecutionResourc
     for nested_call in &top_call.borrow().nested_calls {
         match nested_call {
             CallTraceNode::EntryPointCall(nested_call) => {
-                execution_resources += &add_execution_resources(nested_call.clone());
+                execution_resources += &nested_call.borrow().used_execution_resources;
             }
             CallTraceNode::DeployWithoutConstructor => {}
         }

crates/forge/tests/data/contracts/gas_checker_proxy.cairo

@@ -1,4 +1,4 @@
-use starknet::ContractAddress;
+use starknet::{ContractAddress, SyscallResult};
 
 #[starknet::interface]
 trait IGasChecker<TContractState> {
@@ -9,25 +9,37 @@ trait IGasChecker<TContractState> {
 #[starknet::interface]
 trait IGasCheckerProxy<TContractState> {
     fn send_l1_message_from_gas_checker(self: @TContractState, address: ContractAddress);
+    fn call_other_contract(
+        self: @TContractState,
+        contract_address: ContractAddress,
+        entry_point_selector: felt252,
+        calldata: Array::<felt252>,
+    ) -> SyscallResult<Span<felt252>>;
 }
 
 #[starknet::contract]
 mod GasCheckerProxy {
-    use starknet::ContractAddress;
-    use super::IGasCheckerDispatcherTrait;
-    use super::IGasCheckerDispatcher;
+    use starknet::{ContractAddress, SyscallResult};
+    use starknet::syscalls::call_contract_syscall;
+    use super::{IGasCheckerDispatcher, IGasCheckerDispatcherTrait};
 
     #[storage]
     struct Storage {}
 
-    #[external(v0)]
+    #[abi(embed_v0)]
     impl IGasCheckerProxy of super::IGasCheckerProxy<ContractState> {
-        fn send_l1_message_from_gas_checker(
-            self: @ContractState,
-            address: ContractAddress)
-        {
+        fn send_l1_message_from_gas_checker(self: @ContractState, address: ContractAddress) {
             let gas_checker = IGasCheckerDispatcher { contract_address: address };
             gas_checker.send_l1_message()
         }
+
+        fn call_other_contract(
+            self: @ContractState,
+            contract_address: ContractAddress,
+            entry_point_selector: felt252,
+            calldata: Array::<felt252>,
+        ) -> SyscallResult<Span<felt252>> {
+            call_contract_syscall(contract_address, entry_point_selector, calldata.span())
+        }
     }
 }

crates/forge/tests/data/contracts/hello_starknet_for_nested_calls.cairo

@@ -0,0 +1,24 @@
+#[starknet::interface]
+pub trait IHelloStarknet<TContractState> {
+    fn example_function(ref self: TContractState);
+}
+
+#[starknet::contract]
+pub mod HelloStarknet {
+    use starknet::SyscallResultTrait;
+    use core::sha256::compute_sha256_u32_array;
+    #[storage]
+    struct Storage {}
+
+    #[abi(embed_v0)]
+    impl HelloStarknetImpl of super::IHelloStarknet<ContractState> {
+        fn example_function(ref self: ContractState) {
+            core::pedersen::pedersen(1, 2);
+            core::keccak::keccak_u256s_le_inputs(array![1].span());
+            let _hash = compute_sha256_u32_array(array![0x68656c6c], 0x6f, 1);
+            starknet::syscalls::get_block_hash_syscall(1).unwrap_syscall();
+            starknet::syscalls::emit_event_syscall(array![1].span(), array![2].span())
+                .unwrap_syscall();
+        }
+    }
+}