Skip to content

Commit 30a7b69

Browse files
authored
Hide sierra tracking test behind feature flag for older scarb (#3119)
## Introduced changes <!-- A brief description of the changes --> - replace feature name for test failing on scheduled ## Checklist <!-- Make sure all of these are complete --> - [ ] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [X] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md`
1 parent eb335c8 commit 30a7b69

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ jobs:
120120

121121
- run: cargo test --package forge --features scarb_2_7_1 --test main e2e::requirements::test_warning_on_scarb_version_below_recommended
122122
- run: cargo test --package forge --features scarb_2_7_1 --lib compatibility_check::tests::warning_requirements
123+
- run: cargo test --package forge --features scarb_2_7_1 --test main e2e::running::sierra_gas_with_older_scarb
123124

124125
# todo(3096): Remove this and the feature as soon as scarb 2.10 is the oldest officially supported version
125126
test-scarb-since-2-10:

crates/forge/tests/e2e/running.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -931,7 +931,7 @@ fn call_nonexistent_selector() {
931931
}
932932

933933
#[test]
934-
#[cfg_attr(feature = "scarb_since_2_10", ignore)]
934+
#[cfg_attr(not(feature = "scarb_2_7_1"), ignore)]
935935
fn sierra_gas_with_older_scarb() {
936936
let temp = setup_package("erc20_package");
937937
let output = test_runner(&temp)

0 commit comments

Comments
 (0)