Optimize tests compilation with --exact flag (#2569)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #2530 

## Introduced changes

- Optimize tests performance when using `--exact` flag
- Display `other filtered out` instead of number of filtered tests. This
is should be brought back and addressed in
#2574

    Before
    ```rust
    Tests: 1 passed, 0 failed, 0 skipped, 0 ignored, 5 filtered out
    ```

    After
    ```rust
Tests: 1 passed, 0 failed, 0 skipped, other ignored, other filtered out
    ```

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Fiiranek <[email protected]>
Co-authored-by: Franciszek Job <[email protected]>

Author: cptartur

CHANGELOG.md

@@ -19,6 +19,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 #### Fixed
 - `account delete` command: It is no longer necessary to provide the `--url` argument each time. Either the `--url` or `--network` argument must be provided, but not both, as they are mutually exclusive.
 
+### Forge
+
+#### Changed
+
+- When using test name filter with `--exact` flag, forge will try to compile only the selected test.
+
 ## [0.31.0] - 2024-09-26
 
 ### Cast

Cargo.lock

@@ -26,21 +26,33 @@ pub(crate) fn print_running_tests(test_target_location: TestTargetLocation, test
     println!("{}", style(plain_text).bold());
 }
 
-pub(crate) fn print_test_summary(summaries: &[TestTargetSummary], filtered: usize) {
+// TODO(#2574): Bring back "filtered out" number in tests summary when running with `--exact` flag
+pub(crate) fn print_test_summary(summaries: &[TestTargetSummary], filtered: Option<usize>) {
     let passed: usize = summaries.iter().map(TestTargetSummary::count_passed).sum();
     let failed: usize = summaries.iter().map(TestTargetSummary::count_failed).sum();
     let skipped: usize = summaries.iter().map(TestTargetSummary::count_skipped).sum();
     let ignored: usize = summaries.iter().map(TestTargetSummary::count_ignored).sum();
 
-    println!(
-        "{}: {} passed, {} failed, {} skipped, {} ignored, {} filtered out",
-        style("Tests").bold(),
-        passed,
-        failed,
-        skipped,
-        ignored,
-        filtered,
-    );
+    if let Some(filtered) = filtered {
+        println!(
+            "{}: {} passed, {} failed, {} skipped, {} ignored, {} filtered out",
+            style("Tests").bold(),
+            passed,
+            failed,
+            skipped,
+            ignored,
+            filtered
+        );
+    } else {
+        println!(
+            "{}: {} passed, {} failed, {} skipped, {} ignored, other filtered out",
+            style("Tests").bold(),
+            passed,
+            failed,
+            skipped,
+            ignored
+        );
+    }
 }
 
 pub(crate) fn print_test_seed(seed: u64) {

crates/forge/src/pretty_printing.rs

@@ -11,7 +11,7 @@ use crate::{
         load_test_artifacts, should_compile_starknet_contract_target,
     },
     shared_cache::FailedTestsCache,
-    test_filter::TestsFilter,
+    test_filter::{NameFilter, TestsFilter},
     warn::{
         warn_if_available_gas_used_with_incompatible_scarb_version,
         warn_if_incompatible_rpc_version,
@@ -172,8 +172,13 @@ pub async fn run_for_package(
         }
     }
 
-    let filtered = all_tests - not_filtered;
-    pretty_printing::print_test_summary(&summaries, filtered);
+    // TODO(#2574): Bring back "filtered out" number in tests summary when running with `--exact` flag
+    if let NameFilter::ExactMatch(_) = tests_filter.name_filter {
+        pretty_printing::print_test_summary(&summaries, None);
+    } else {
+        let filtered = all_tests - not_filtered;
+        pretty_printing::print_test_summary(&summaries, Some(filtered));
+    }
 
     let any_fuzz_test_was_run = summaries.iter().any(|test_target_summary| {
         test_target_summary

crates/forge/src/run_tests/package.rs

@@ -16,6 +16,7 @@ use scarb_api::{
     target_dir_for_workspace, ScarbCommand,
 };
 use scarb_ui::args::PackagesFilter;
+use shared::consts::SNFORGE_TEST_FILTER;
 use std::env;
 
 #[allow(clippy::too_many_lines)]
@@ -44,6 +45,15 @@ pub async fn run_for_workspace(args: TestArgs) -> Result<ExitStatus> {
 
     let filter = PackagesFilter::generate_for::<Metadata>(packages.iter());
 
+    if args.exact {
+        let test_filter = args.test_filter.clone();
+        if let Some(last_filter) =
+            test_filter.and_then(|filter| filter.split("::").last().map(String::from))
+        {
+            set_forge_test_filter(last_filter);
+        }
+    }
+
     build_artifacts_with_scarb(
         filter.clone(),
         args.features.clone(),
@@ -80,6 +90,10 @@ pub async fn run_for_workspace(args: TestArgs) -> Result<ExitStatus> {
     pretty_printing::print_latest_blocks_numbers(block_number_map.get_url_to_latest_block_number());
     pretty_printing::print_failures(&all_failed_tests);
 
+    if args.exact {
+        unset_forge_test_filter();
+    }
+
     Ok(if all_failed_tests.is_empty() {
         ExitStatus::Success
     } else {
@@ -101,3 +115,11 @@ fn extract_failed_tests(
             )
         })
 }
+
+fn set_forge_test_filter(test_filter: String) {
+    env::set_var(SNFORGE_TEST_FILTER, test_filter);
+}
+
+fn unset_forge_test_filter() {
+    env::remove_var(SNFORGE_TEST_FILTER);
+}

crates/forge/src/run_tests/workspace.rs

@@ -7,7 +7,7 @@ use forge_runner::TestCaseFilter;
 // Specifies what tests should be included
 pub struct TestsFilter {
     // based on name
-    name_filter: NameFilter,
+    pub(crate) name_filter: NameFilter,
     // based on `#[ignore]` attribute
     ignored_filter: IgnoredFilter,
     // based on rerun_failed flag

crates/forge/src/test_filter.rs

@@ -0,0 +1,10 @@
+[package]
+name = "duplicated_test_names"
+version = "0.1.0"
+edition = "2023_11"
+
+[dev-dependencies]
+snforge_std = { path = "../../../../../snforge_std" }
+
+[scripts]
+test = "snforge test"

crates/forge/tests/data/duplicated_test_names/Scarb.toml

@@ -0,0 +1 @@
+

crates/forge/tests/data/duplicated_test_names/src/lib.cairo

@@ -0,0 +1,4 @@
+#[test]
+fn test_simple() {
+    assert(1 == 1, 'simple check');
+}

crates/forge/tests/data/duplicated_test_names/tests/tests_a.cairo

@@ -0,0 +1,4 @@
+#[test]
+fn test_simple() {
+    assert(1 == 1, 'simple check');
+}