Fix negative values in arguments (#3205)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #3203

## Introduced changes

<!-- A brief description of the changes -->

-

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

Author: cptartur

CHANGELOG.md

@@ -23,6 +23,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - The state correctly reverts after failed internal calls
 
+### Cast
+
+#### Fixed
+
+- Bug that prevented from passing values to `--arguments` that started with a leading minus `-` sign.
+
 ## [0.41.0] - 2025-04-08
 
 ### Forge

crates/data-transformer/tests/data/data_transformer/Scarb.toml

@@ -6,12 +6,12 @@ edition = "2024_07"
 # See more keys and their definitions at https://docs.swmansion.com/scarb/docs/reference/manifest.html
 
 [dependencies]
-starknet = "2.10.0"
+starknet = "2.9.4"
 alexandria_data_structures = "0.4.0"
 
 [dev-dependencies]
 snforge_std = "0.39.0"
-assert_macros = "2.10.0"
+assert_macros = "2.9.4"
 
 [[target.starknet-contract]]
 sierra = true

crates/data-transformer/tests/data/data_transformer/src/lib.cairo

@@ -59,6 +59,7 @@ pub trait IDataTransformer<TContractState> {
         ref self: TContractState, a: BitArray, b: alexandria_data_structures::bit_array::BitArray,
     );
     fn span_fn(ref self: TContractState, a: Span<felt252>);
+    fn multiple_signed_fn(ref self: TContractState, a: i32, b: i8);
 }
 
 #[starknet::contract]
@@ -101,5 +102,6 @@ mod DataTransformer {
             b: alexandria_data_structures::bit_array::BitArray,
         ) {}
         fn span_fn(ref self: ContractState, a: Span<felt252>) {}
+        fn multiple_signed_fn(ref self: ContractState, a: i32, b: i8) {}
     }
 }

crates/data-transformer/tests/integration.rs

@@ -15,7 +15,7 @@ use url::Url;
 
 // Deployment of contract from /tests/data/data_transformer
 const TEST_CLASS_HASH: Felt =
-    Felt::from_hex_unchecked("0x032e6763d5e778f153e5b6ea44200d94ec89aac7b42a0aef0e4e0caac8dafdab");
+    Felt::from_hex_unchecked("0x0786d1f010d66f838837290e472415186ba6a789fb446e7f92e444bed7b5d9c0");
 
 static CLASS: OnceCell<ContractClass> = OnceCell::const_new();
 

crates/sncast/src/main.rs

@@ -164,7 +164,7 @@ pub struct Arguments {
     pub calldata: Option<Vec<String>>,
 
     // Arguments of the called function as a comma-separated string of Cairo expressions
-    #[arg(long)]
+    #[arg(long, allow_hyphen_values = true)]
     pub arguments: Option<String>,
 }
 

crates/sncast/tests/e2e/call.rs

@@ -3,11 +3,12 @@ use crate::helpers::constants::{
 };
 use crate::helpers::fixtures::invoke_contract;
 use crate::helpers::runner::runner;
+use crate::helpers::shell::os_specific_shell;
+use camino::Utf8PathBuf;
 use indoc::indoc;
 use shared::test_utils::output_assert::assert_stderr_contains;
-use snapbox::cmd::{Command, cargo_bin};
+use snapbox::cmd::cargo_bin;
 use sncast::helpers::fee::FeeSettings;
-use std::path::PathBuf;
 
 #[test]
 fn test_happy_case() {
@@ -242,21 +243,20 @@ fn test_wrong_block_id() {
 
 #[test]
 fn test_happy_case_shell() {
-    let script_extension = if cfg!(windows) { ".ps1" } else { ".sh" };
-    let test_path = PathBuf::from(format!("tests/shell/call{script_extension}"))
-        .canonicalize()
-        .unwrap();
     let binary_path = cargo_bin!("sncast");
+    let command = os_specific_shell(&Utf8PathBuf::from("tests/shell/call"));
 
-    let command = if cfg!(windows) {
-        Command::new("powershell")
-            .arg("-ExecutionPolicy")
-            .arg("Bypass")
-            .arg("-File")
-            .arg(test_path)
-    } else {
-        Command::new(test_path)
-    };
+    let snapbox = command
+        .arg(binary_path)
+        .arg(URL)
+        .arg(DATA_TRANSFORMER_CONTRACT_ADDRESS_SEPOLIA);
+    snapbox.assert().success();
+}
+
+#[test]
+fn test_leading_negative_values() {
+    let binary_path = cargo_bin!("sncast");
+    let command = os_specific_shell(&Utf8PathBuf::from("tests/shell/call_unsigned"));
 
     let snapbox = command
         .arg(binary_path)

crates/sncast/tests/e2e/deploy.rs

@@ -8,15 +8,16 @@ use crate::helpers::fixtures::{
     get_transaction_hash, get_transaction_receipt,
 };
 use crate::helpers::runner::runner;
+use crate::helpers::shell::os_specific_shell;
+use camino::Utf8PathBuf;
 use indoc::indoc;
 use shared::test_utils::output_assert::{assert_stderr_contains, assert_stdout_contains};
-use snapbox::cmd::{Command, cargo_bin};
+use snapbox::cmd::cargo_bin;
 use sncast::AccountType;
 use sncast::helpers::constants::OZ_CLASS_HASH;
 use sncast::helpers::fee::FeeArgs;
 use starknet::core::types::TransactionReceipt::Deploy;
 use starknet_types_core::felt::Felt;
-use std::path::PathBuf;
 use tempfile::tempdir;
 use test_case::test_case;
 
@@ -351,22 +352,8 @@ fn test_too_low_gas() {
 #[tokio::test]
 async fn test_happy_case_shell() {
     let tempdir = create_and_deploy_oz_account().await;
-
-    let script_extension = if cfg!(windows) { ".ps1" } else { ".sh" };
-    let test_path = PathBuf::from(format!("tests/shell/deploy{script_extension}"))
-        .canonicalize()
-        .unwrap();
     let binary_path = cargo_bin!("sncast");
-
-    let command = if cfg!(windows) {
-        Command::new("powershell")
-            .arg("-ExecutionPolicy")
-            .arg("Bypass")
-            .arg("-File")
-            .arg(test_path)
-    } else {
-        Command::new(test_path)
-    };
+    let command = os_specific_shell(&Utf8PathBuf::from("tests/shell/deploy"));
 
     let snapbox = command
         .current_dir(tempdir.path())

crates/sncast/tests/e2e/invoke.rs

@@ -8,15 +8,16 @@ use crate::helpers::fixtures::{
     get_transaction_hash, get_transaction_receipt,
 };
 use crate::helpers::runner::runner;
+use crate::helpers::shell::os_specific_shell;
+use camino::Utf8PathBuf;
 use indoc::indoc;
 use shared::test_utils::output_assert::{assert_stderr_contains, assert_stdout_contains};
-use snapbox::cmd::{Command, cargo_bin};
+use snapbox::cmd::cargo_bin;
 use sncast::AccountType;
 use sncast::helpers::constants::{ARGENT_CLASS_HASH, OZ_CLASS_HASH};
 use sncast::helpers::fee::FeeArgs;
 use starknet::core::types::TransactionReceipt::Invoke;
 use starknet_types_core::felt::Felt;
-use std::path::PathBuf;
 use tempfile::tempdir;
 use test_case::test_case;
 
@@ -339,22 +340,8 @@ async fn test_happy_case_cairo_expression_calldata() {
 #[tokio::test]
 async fn test_happy_case_shell() {
     let tempdir = create_and_deploy_oz_account().await;
-
-    let script_extension = if cfg!(windows) { ".ps1" } else { ".sh" };
-    let test_path = PathBuf::from(format!("tests/shell/invoke{script_extension}"))
-        .canonicalize()
-        .unwrap();
     let binary_path = cargo_bin!("sncast");
-
-    let command = if cfg!(windows) {
-        Command::new("powershell")
-            .arg("-ExecutionPolicy")
-            .arg("Bypass")
-            .arg("-File")
-            .arg(test_path)
-    } else {
-        Command::new(test_path)
-    };
+    let command = os_specific_shell(&Utf8PathBuf::from("tests/shell/invoke"));
 
     let snapbox = command
         .current_dir(tempdir.path())

crates/sncast/tests/helpers/constants.rs

@@ -11,7 +11,7 @@ pub const NETWORK: &str = "testnet";
 pub const SEED: u32 = 1_053_545_548;
 
 // Block number used by devnet to fork the Sepolia testnet network in the tests
-pub const FORK_BLOCK_NUMBER: u32 = 369_169;
+pub const FORK_BLOCK_NUMBER: u32 = 721_720;
 
 pub const CONTRACTS_DIR: &str = "tests/data/contracts";
 pub const SCRIPTS_DIR: &str = "tests/data/scripts";
@@ -38,4 +38,4 @@ pub const CONSTRUCTOR_WITH_PARAMS_CONTRACT_CLASS_HASH_SEPOLIA: &str =
     "0x59426c817fb8103edebdbf1712fa084c6744b2829db9c62d1ea4dce14ee6ded";
 
 pub const DATA_TRANSFORMER_CONTRACT_ADDRESS_SEPOLIA: &str =
-    "0x016ad425af4585102e139d4fb2c76ce786d1aaa1cfcd88a51f3ed66601b23cdd";
+    "0x00351c816183324878714973f3da1a43c1a40d661b8dac5cb69294cc333342ed";

crates/sncast/tests/helpers/mod.rs

@@ -4,3 +4,4 @@ pub mod env;
 pub mod fee;
 pub mod fixtures;
 pub mod runner;
+pub mod shell;