Fix passing non-existent profile to scarb (#1695)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #1693

## Introduced changes

<!-- A brief description of the changes -->

- fixes a bug, where we allowed passing non existent profile to scarb,
which resulted with missing artifacts error

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [X] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [X] Added changes to `CHANGELOG.md`

Author: THenry14

CHANGELOG.md

@@ -7,9 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Cast
+
+#### Changed
+
+- fixed a bug where a profile was passed to scarb even when it did not exist
+
 ### Forge
 
 #### Added
+
 - `map_string_error` for use with dispatchers, which automatically converts string errors from the syscall result (read more [here](https://foundry-rs.github.io/starknet-foundry/testing/contracts#handling-errors))
 
 ## [0.17.0] - 2024-02-07

crates/sncast/src/helpers/scarb_utils.rs

@@ -1,3 +1,4 @@
+use crate::response::print::print_as_warning;
 use anyhow::{anyhow, Context, Result};
 use camino::{Utf8Path, Utf8PathBuf};
 use scarb_api::{
@@ -154,7 +155,15 @@ pub fn build_and_load_artifacts(
     build(package, config).map_err(|e| anyhow!(format!("Failed to build using scarb; {e}")))?;
 
     let metadata = get_scarb_metadata_with_deps(&config.scarb_toml_path)?;
-    get_contracts_map(&metadata, &package.id, Some(&config.profile))
+    if metadata.profiles.contains(&config.profile) {
+        get_contracts_map(&metadata, &package.id, Some(&config.profile))
+    } else {
+        let profile = &config.profile;
+        print_as_warning(&anyhow!(
+            "Profile {profile} does not exist in scarb, using default 'dev' profile."
+        ));
+        get_contracts_map(&metadata, &package.id, None)
+    }
 }
 
 #[cfg(test)]

crates/sncast/tests/data/files/correct_snfoundry.toml

@@ -21,3 +21,7 @@ keystore = "../keystore"
 url = "http://127.0.0.1:5055/rpc"
 accounts-file = "../account-file"
 account = "user3"
+
+[sncast.profile5]
+url = "http://127.0.0.1:5055/rpc"
+account = "user8"

crates/sncast/tests/e2e/declare.rs

@@ -5,7 +5,9 @@ use crate::helpers::fixtures::{
 };
 use indoc::indoc;
 use snapbox::cmd::{cargo_bin, Command};
+use sncast::helpers::constants::CONFIG_FILENAME;
 use starknet::core::types::TransactionReceipt::Declare;
+use std::fs;
 
 #[tokio::test]
 async fn test_happy_case() {
@@ -360,3 +362,39 @@ async fn test_worskpaces_package_no_contract() {
         error: Failed to find whatever artifact in starknet_artifacts.json file[..]
     "});
 }
+
+#[tokio::test]
+async fn test_no_scarb_profile() {
+    let contract_path =
+        duplicate_contract_directory_with_salt(CONTRACTS_DIR.to_string() + "/map", "put", "69");
+    fs::copy(
+        "tests/data/files/correct_snfoundry.toml",
+        contract_path.path().join(CONFIG_FILENAME),
+    )
+    .expect("Failed to copy config file to temp dir");
+    let accounts_json_path = get_accounts_path("tests/data/accounts/accounts.json");
+    let args = vec![
+        "--url",
+        URL,
+        "--accounts-file",
+        accounts_json_path.as_str(),
+        "--profile",
+        "profile5",
+        "declare",
+        "--contract-name",
+        "Map",
+        "--max-fee",
+        "99999999999999999",
+    ];
+
+    let snapbox = Command::new(cargo_bin!("sncast"))
+        .current_dir(contract_path.path())
+        .args(args);
+    snapbox.assert().success().stdout_matches(indoc! {r"
+        ...
+        Warning: Profile profile5 does not exist in scarb, using default 'dev' profile.
+        command: declare
+        class_hash: [..]
+        transaction_hash: [..]
+    "});
+}