fix(systemd): Add .service suffix to all systemctl commands

Fixes systemctl enable/disable/start/stop/restart commands to consistently
use the .service suffix for both concourse-server and concourse-worker.

This resolves a compatibility issue with systemd 255 on Ubuntu 24.04 where
systemctl enable without the .service suffix can fail with exit code 1.

The error was:
  Status check failed: Command '['systemctl', 'enable', 'concourse-server']'
  returned non-zero exit status 1.

Changed files:
- lib/concourse_web.py: Add .service to all systemctl commands
- lib/concourse_worker.py: Add .service to all systemctl commands
- lib/concourse_helper.py: Add .service to restart/kill commands

Fixes: #104 (GitHub Actions CI failure in Deploy step)

Author: fourdollars

lib/concourse_helper.py

@@ -368,16 +368,22 @@ def restart_services(self, graceful: bool = True):
         try:
             if graceful:
                 # Graceful restart - restart in order
-                subprocess.run(["systemctl", "restart", "concourse-server"], check=True)
-                subprocess.run(["systemctl", "restart", "concourse-worker"], check=True)
+                subprocess.run(
+                    ["systemctl", "restart", "concourse-server.service"], check=True
+                )
+                subprocess.run(
+                    ["systemctl", "restart", "concourse-worker.service"], check=True
+                )
                 logger.info("Services restarted gracefully")
             else:
                 # Force restart
                 subprocess.run(
-                    ["systemctl", "kill", "-9", "concourse-server"], capture_output=True
+                    ["systemctl", "kill", "-9", "concourse-server.service"],
+                    capture_output=True,
                 )
                 subprocess.run(
-                    ["systemctl", "kill", "-9", "concourse-worker"], capture_output=True
+                    ["systemctl", "kill", "-9", "concourse-worker.service"],
+                    capture_output=True,
                 )
                 self.start_services()
                 logger.info("Services force restarted")

lib/concourse_web.py

@@ -272,8 +272,12 @@ def _write_config(self, config: dict):
     def start_service(self):
         """Start Concourse web server service"""
         try:
-            subprocess.run(["systemctl", "enable", "concourse-server"], check=True)
-            subprocess.run(["systemctl", "start", "concourse-server"], check=True)
+            subprocess.run(
+                ["systemctl", "enable", "concourse-server.service"], check=True
+            )
+            subprocess.run(
+                ["systemctl", "start", "concourse-server.service"], check=True
+            )
             logger.info("Web server service started")
         except subprocess.CalledProcessError as e:
             logger.error(f"Failed to start web server: {e}")
@@ -283,10 +287,11 @@ def stop_service(self):
         """Stop Concourse web server service"""
         try:
             subprocess.run(
-                ["systemctl", "stop", "concourse-server"], capture_output=True
+                ["systemctl", "stop", "concourse-server.service"], capture_output=True
             )
             subprocess.run(
-                ["systemctl", "disable", "concourse-server"], capture_output=True
+                ["systemctl", "disable", "concourse-server.service"],
+                capture_output=True,
             )
             logger.info("Web server service stopped")
         except subprocess.CalledProcessError as e:
@@ -295,7 +300,9 @@ def stop_service(self):
     def restart_service(self):
         """Restart Concourse web server service"""
         try:
-            subprocess.run(["systemctl", "restart", "concourse-server"], check=True)
+            subprocess.run(
+                ["systemctl", "restart", "concourse-server.service"], check=True
+            )
             logger.info("Web server service restarted")
         except subprocess.CalledProcessError as e:
             logger.error(f"Failed to restart web server: {e}")
@@ -305,7 +312,7 @@ def is_running(self) -> bool:
         """Check if web server is running"""
         try:
             result = subprocess.run(
-                ["systemctl", "is-active", "concourse-server"],
+                ["systemctl", "is-active", "concourse-server.service"],
                 capture_output=True,
                 text=True,
             )

lib/concourse_worker.py

@@ -1085,8 +1085,12 @@ def install_folder_mount_wrapper(self):
     def start_service(self):
         """Start Concourse worker service"""
         try:
-            subprocess.run(["systemctl", "enable", "concourse-worker"], check=True)
-            subprocess.run(["systemctl", "start", "concourse-worker"], check=True)
+            subprocess.run(
+                ["systemctl", "enable", "concourse-worker.service"], check=True
+            )
+            subprocess.run(
+                ["systemctl", "start", "concourse-worker.service"], check=True
+            )
             logger.info("Worker service started")
         except subprocess.CalledProcessError as e:
             logger.error(f"Failed to start worker: {e}")
@@ -1096,10 +1100,11 @@ def stop_service(self):
         """Stop Concourse worker service"""
         try:
             subprocess.run(
-                ["systemctl", "stop", "concourse-worker"], capture_output=True
+                ["systemctl", "stop", "concourse-worker.service"], capture_output=True
             )
             subprocess.run(
-                ["systemctl", "disable", "concourse-worker"], capture_output=True
+                ["systemctl", "disable", "concourse-worker.service"],
+                capture_output=True,
             )
             logger.info("Worker service stopped")
         except subprocess.CalledProcessError as e:
@@ -1108,7 +1113,9 @@ def stop_service(self):
     def restart_service(self):
         """Restart Concourse worker service"""
         try:
-            subprocess.run(["systemctl", "restart", "concourse-worker"], check=True)
+            subprocess.run(
+                ["systemctl", "restart", "concourse-worker.service"], check=True
+            )
             logger.info("Worker service restarted")
         except subprocess.CalledProcessError as e:
             logger.error(f"Failed to restart worker: {e}")
@@ -1118,7 +1125,7 @@ def is_running(self) -> bool:
         """Check if worker is running"""
         try:
             result = subprocess.run(
-                ["systemctl", "is-active", "concourse-worker"],
+                ["systemctl", "is-active", "concourse-worker.service"],
                 capture_output=True,
                 text=True,
             )