Skip to content

Commit a888c64

Browse files
committed
c fixes
1 parent d1c6528 commit a888c64

3 files changed

Lines changed: 14 additions & 14 deletions

File tree

trilogy-llvm/core/core.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
#include "types.h"
1818
#include <assert.h>
1919
#include <errno.h>
20-
#include <execinfo.h>
2120
#include <stdbool.h>
2221
#include <stdint.h>
2322
#include <stdio.h>

trilogy-llvm/core/trilogy_callable.c

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -242,43 +242,44 @@ void* trilogy_continuation_untag(trilogy_callable_value* val) {
242242
return (void*)val->function;
243243
}
244244

245-
static void backtrace_frame(trilogy_value* rv, trilogy_callable_value* val) {
246-
if (val->metadata == NULL) {
245+
static void
246+
backtrace_frame(trilogy_value* rv, const trilogy_callable_data* metadata) {
247+
if (metadata == NULL) {
247248
*rv = trilogy_unit;
248249
return;
249250
}
250251
trilogy_record_value* record = trilogy_record_init_cap(rv, 8);
251252
trilogy_value key = trilogy_undefined;
252253
trilogy_value value = trilogy_undefined;
253254

254-
trilogy_string_init_from_c(&value, val->metadata->name);
255+
trilogy_string_init_from_c(&value, metadata->name);
255256
trilogy_string_init_from_c(&key, "name");
256257
trilogy_record_insert(record, &key, &value);
257258

258-
trilogy_string_init_from_c(&value, val->metadata->path);
259+
trilogy_string_init_from_c(&value, metadata->path);
259260
trilogy_string_init_from_c(&key, "path");
260261
trilogy_record_insert(record, &key, &value);
261262

262-
trilogy_number_init_u64(&value, val->metadata->arity);
263+
trilogy_number_init_u64(&value, metadata->arity);
263264
trilogy_string_init_from_c(&key, "arity");
264265
trilogy_record_insert(record, &key, &value);
265266

266267
trilogy_value start = trilogy_undefined;
267268
trilogy_value end = trilogy_undefined;
268269
trilogy_value line = trilogy_undefined;
269270
trilogy_value col = trilogy_undefined;
270-
trilogy_number_init_u64(&line, val->metadata->span.start.line);
271-
trilogy_number_init_u64(&col, val->metadata->span.start.column);
271+
trilogy_number_init_u64(&line, metadata->span.start.line);
272+
trilogy_number_init_u64(&col, metadata->span.start.column);
272273
trilogy_tuple_init_take(&start, &line, &col);
273-
trilogy_number_init_u64(&line, val->metadata->span.end.line);
274-
trilogy_number_init_u64(&col, val->metadata->span.end.column);
274+
trilogy_number_init_u64(&line, metadata->span.end.line);
275+
trilogy_number_init_u64(&col, metadata->span.end.column);
275276
trilogy_tuple_init_take(&end, &line, &col);
276277
trilogy_tuple_init_take(&value, &start, &end);
277278
trilogy_string_init_from_c(&key, "span");
278279
trilogy_record_insert(record, &key, &value);
279280

280-
if (val->metadata->parent) {
281-
backtrace_frame(&value, val->metadata->parent);
281+
if (metadata->parent) {
282+
backtrace_frame(&value, metadata->parent);
282283
trilogy_string_init_from_c(&key, "scope");
283284
trilogy_record_insert(record, &key, &value);
284285
}
@@ -290,7 +291,7 @@ void trilogy_callable_backtrace(
290291
trilogy_array_value* array = trilogy_array_init_empty(rv);
291292
while (val != NULL) {
292293
trilogy_value frame = trilogy_undefined;
293-
backtrace_frame(&frame, val);
294+
backtrace_frame(&frame, val->metadata);
294295
val = val->return_to;
295296
trilogy_array_push(array, &frame);
296297
}

trilogy-llvm/core/trilogy_module.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ typedef trilogy_value* (*closure_accessor)(trilogy_value*, trilogy_value*);
7171
void trilogy_module_find(
7272
trilogy_value* tv, trilogy_module* module, uint64_t id
7373
) {
74-
trilogy_module_data* module_data = module->module_data;
74+
const trilogy_module_data* module_data = module->module_data;
7575
// NOTE: modules are typically quite small, so linear search is usually
7676
// going to be just fine, but if someone makes a pathological module we
7777
// might do much better to binary search this.

0 commit comments

Comments
 (0)