Fix issue with DEP004 being raised incorrectly (#376)

* Fix issue with DEP004 being raised incorrectly if a dependency is both a regular and a dev dependency

Author: fpgmaas

deptry/issues_finder/misplaced_dev.py

@@ -43,12 +43,15 @@ def find(self) -> list[Violation]:
         return misplaced_dev_dependencies
 
     def _is_development_dependency(self, module: Module, corresponding_package_name: str) -> bool:
-        if not module.is_provided_by_dev_dependency:
+        # Module can be provided both by a regular and by a development dependency.
+        # Only continue if module is ONLY provided by a dev dependency.
+        if not module.is_provided_by_dev_dependency or module.is_provided_by_dependency:
             return False
 
         if module.name in self.ignored_modules:
             logging.debug(
-                f"Module '{corresponding_package_name}' found to be a misplaced development dependency, but ignoring."
+                f"Dependency '{corresponding_package_name}' found to be a misplaced development dependency, but"
+                " ignoring."
             )
             return False
 

tests/unit/issues_finder/test_misplaced_dev.py

@@ -20,3 +20,21 @@ def test_simple() -> None:
     assert MisplacedDevDependenciesFinder(modules_locations, dependencies).find() == [
         MisplacedDevDependencyViolation(module_foo, location) for location in module_foo_locations
     ]
+
+
+def test_regular_and_dev_dependency() -> None:
+    """
+    If a dependency is both a regular and a development dependency, no 'misplaced dev dependency' violation
+    should be detected if it is used in the code base.
+    """
+
+    dependencies = [Dependency("foo", Path("pyproject.toml"))]
+
+    module_foo_locations = [Location(Path("foo.py"), 1, 2)]
+    module_foo = Module(
+        "foo", dev_top_levels=["foo"], is_provided_by_dev_dependency=True, is_provided_by_dependency=True
+    )
+
+    modules_locations = [ModuleLocations(module_foo, module_foo_locations)]
+
+    assert not MisplacedDevDependenciesFinder(modules_locations, dependencies).find()