Fix weather in XP11

Author: fpw

CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.9)
-project(AviTab VERSION 0.6.1 DESCRIPTION "AviTab X-Plane plugin")
+project(AviTab VERSION 0.6.2 DESCRIPTION "AviTab X-Plane plugin")
 
 if (NOT "$ENV{NAVIGRAPH_SECRET}" STREQUAL "")
     set(NAVIGRAPH_SECRET "$ENV{NAVIGRAPH_SECRET}" CACHE INTERNAL "Copied from environment variable")

lib/cairo

@@ -0,0 +1 @@
+Subproject commit aee96d175d8349945a6d1948a56abd4b4ec6ad84

lib/litehtml

@@ -0,0 +1 @@
+Subproject commit f06d139a0c35f280828ff299530474a324c7640e

lib/pixman

@@ -0,0 +1 @@
+Subproject commit 9b49f4e08751885289333fed652bf5e0f45976b4

src/environment/xplane/XPlaneEnvironment.cpp

@@ -44,8 +44,9 @@ XPlaneEnvironment::XPlaneEnvironment() {
     XPLMHostApplicationID hostId;
     XPLMGetVersions(&xpVersion, &xplmVersion, &hostId);
     if (xplmVersion >= 400) {
-        isXP12 = true;
         getMetar = (GetMetarPtr) XPLMFindSymbol("XPLMGetMETARForAirport");
+    } else {
+        getMetar = nullptr;
     }
 
     updatePlaneCount();
@@ -363,18 +364,14 @@ double XPlaneEnvironment::getMagneticVariation(double lat, double lon) {
 
 std::string XPlaneEnvironment::getMETARForAirport(const std::string &icao) {
     std::string metar, timestamp;
-    if (isXP12) {
+    if (getMetar) {
         std::promise<std::string> dataPromise;
         auto futureData = dataPromise.get_future();
 
         auto startAt = std::chrono::steady_clock::now();
         runInEnvironment([this, icao, &dataPromise] () {
             XPLMFixedString150_t buf;
-            if (getMetar) {
-                getMetar(icao.c_str(), &buf);
-            } else {
-                strcpy(buf.buffer, "XPLM Error");
-            }
+            getMetar(icao.c_str(), &buf);
             dataPromise.set_value(std::string(buf.buffer));
         });
 

src/environment/xplane/XPlaneEnvironment.h

@@ -83,7 +83,6 @@ class XPlaneEnvironment: public Environment {
     Location nullLocation { 0, 0, 0, 0 };
     std::atomic<float> lastDrawTime{};
     std::string aircraftPath;
-    bool isXP12;
 
     // State
     std::mutex stateMutex;