Update shard initialization to include a TODO comment regarding potential memory leak

sinkingsugar · sinkingsugar · commit a2cc10ac4ecb · 2025-03-14T18:35:18.000+08:00
- Added a comment to the shard initialization code indicating that the reference count management may not be handled properly, suggesting a potential memory leak issue.
diff --git a/include/shards/shards.swift b/include/shards/shards.swift
@@ -1233,7 +1233,7 @@ class ShardController: Equatable, Identifiable {
             $0.baseAddress
         }
         cname.len = UInt64(n.count - 1)
-        self.init(native: G.Core.pointee.createShard(cname)!)
+        self.init(native: G.Core.pointee.createShard(cname)!) // TODO, this code is old, this might leak as its ref count is not managed
     }
 
     init(native: ShardPtr) {

Original file line number	Diff line number	Diff line change
`@@ -1233,7 +1233,7 @@ class ShardController: Equatable, Identifiable {`
`1233`	`1233`	`$0.baseAddress`
`1234`	`1234`	`}`
`1235`	`1235`	`cname.len = UInt64(n.count - 1)`
`1236`		`- self.init(native: G.Core.pointee.createShard(cname)!)`
	`1236`	`+ self.init(native: G.Core.pointee.createShard(cname)!) // TODO, this code is old, this might leak as its ref count is not managed`
`1237`	`1237`	`}`
`1238`	`1238`
`1239`	`1239`	`init(native: ShardPtr) {`