chore: fix lint findings

Author: jddunn

codecov.yml

@@ -30,3 +30,5 @@ comment:
   require_base: no
   require_head: yes
 
+
+

docs/RELEASING.md

@@ -153,3 +153,5 @@ Fix tests locally before releasing. Do not skip tests.
 
 
 
+
+

eslint.config.js

@@ -14,6 +14,7 @@ export default tseslint.config(
       '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
       '@typescript-eslint/no-empty-function': 'off',
       '@typescript-eslint/ban-ts-comment': 'off',
+      '@typescript-eslint/no-unused-expressions': 'off',
       'no-console': 'off',
     },
   }

package.json

@@ -21,7 +21,7 @@
     "clean": "rimraf dist tsconfig.build.tsbuildinfo",
     "build": "npm run clean && tsc -p tsconfig.build.json && tsc-alias -p tsconfig.build.json && node scripts/fix-esm-imports.mjs",
     "typecheck": "tsc --noEmit",
-    "lint": "eslint \"src/**/*.{ts,js}\"",
+    "lint": "node scripts/strip-nbsp.mjs && eslint \"src/**/*.{ts,js}\"",
     "test": "vitest run",
     "dev:test": "vitest",
     "docs:clean": "rimraf docs/api ../../docs-generated/library ../../docs-generated/api",

scripts/strip-nbsp.mjs

@@ -0,0 +1,49 @@
+import fs from 'fs';
+import path from 'path';
+import { fileURLToPath } from 'url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SRC_DIR = path.join(ROOT, 'src');
+const TARGET_EXTS = new Set(['.ts', '.tsx', '.js', '.jsx']);
+const isWindows = process.platform === 'win32';
+
+function normalizePath(p) {
+  return isWindows && p.startsWith('/') ? p.slice(1) : p;
+}
+
+function walk(dir, acc) {
+  const entries = fs.readdirSync(dir, { withFileTypes: true });
+  for (const entry of entries) {
+    if (entry.name === 'node_modules' || entry.name === 'dist') continue;
+    const full = path.join(dir, entry.name);
+    if (entry.isDirectory()) {
+      walk(full, acc);
+    } else if (TARGET_EXTS.has(path.extname(entry.name))) {
+      acc.push(full);
+    }
+  }
+  return acc;
+}
+
+const files = walk(SRC_DIR, []);
+let changed = 0;
+let stripped = 0;
+
+for (const file of files) {
+  const raw = fs.readFileSync(file, 'utf8');
+  const cleaned = raw
+    // Normalize NBSP and other exotic spaces to regular space
+    .replace(/[\u00a0\u1680\u2000-\u200a\u202f\u205f\u3000]/g, ' ')
+    // Remove zero-width chars if any snuck in
+    .replace(/[\u200b\u200c\u200d\ufeff]/g, '');
+
+  if (cleaned !== raw) {
+    fs.writeFileSync(file, cleaned, 'utf8');
+    changed += 1;
+    stripped += (raw.length - cleaned.length);
+  }
+}
+
+console.log(`strip-nbsp: cleaned ${changed} files, removed ${stripped} chars`);
+
+

src/api/AgentOSOrchestrator.ts

@@ -811,7 +811,7 @@ export class AgentOSOrchestrator {
           );
         }
         break;
-      case GMIOutputChunkType.ERROR:
+      case GMIOutputChunkType.ERROR: {
         const errDetails = gmiChunk.errorDetails || { message: gmiChunk.content };
         await this.pushErrorChunk(
           agentOSStreamId, personaId, gmiInstanceIdForChunks,
@@ -825,6 +825,7 @@ export class AgentOSOrchestrator {
           await this.dependencies.streamingManager.closeStream(agentOSStreamId, `GMI stream error: ${errDetails.message || String(gmiChunk.content)}`);
         }
         break;
+      }
       case GMIOutputChunkType.FINAL_RESPONSE_MARKER:
         // This chunk signals the end of GMI's streaming.
         // The actual final content should have been accumulated or is in this chunk's content/metadata.
@@ -834,24 +835,24 @@ export class AgentOSOrchestrator {
         // For now, if GMI explicitly sends this, we ensure the stream is marked for closure.
         // The main _processTurnInternal loop will handle the comprehensive AgentOSFinalResponseChunk.
         if (gmiChunk.isFinal) { // This marker SHOULD imply isFinal=true
-             if (this.config.enableConversationalPersistence && conversationContext) {
-                await this.dependencies.conversationManager.saveConversation(conversationContext);
-             }
-            // This is a simplified final response based *only* on this marker chunk.
-            // A more robust solution accumulates all data through the turn.
-            await this.pushChunkToStream(
-                agentOSStreamId, AgentOSResponseChunkType.FINAL_RESPONSE,
-                gmiInstanceIdForChunks, personaId, true,
-                {
-                    finalResponseText: typeof gmiChunk.content === 'string' ? gmiChunk.content : "Processing complete.",
-                    // other fields like usage, trace would need to be on the FINAL_RESPONSE_MARKER content
-                    // or aggregated throughout the turn.
-                    updatedConversationContext: conversationContext.toJSON(),
-                    activePersonaDetails: snapshotPersonaDetails(gmi.getPersona?.()),
-                }
-            );
-            this.activeStreamContexts.delete(agentOSStreamId);
-            await this.dependencies.streamingManager.closeStream(agentOSStreamId, "GMI processing complete (final marker).");
+          if (this.config.enableConversationalPersistence && conversationContext) {
+            await this.dependencies.conversationManager.saveConversation(conversationContext);
+          }
+          // This is a simplified final response based *only* on this marker chunk.
+          // A more robust solution accumulates all data through the turn.
+          await this.pushChunkToStream(
+            agentOSStreamId, AgentOSResponseChunkType.FINAL_RESPONSE,
+            gmiInstanceIdForChunks, personaId, true,
+            {
+              finalResponseText: typeof gmiChunk.content === 'string' ? gmiChunk.content : "Processing complete.",
+              // other fields like usage, trace would need to be on the FINAL_RESPONSE_MARKER content
+              // or aggregated throughout the turn.
+              updatedConversationContext: conversationContext.toJSON(),
+              activePersonaDetails: snapshotPersonaDetails(gmi.getPersona?.()),
+            }
+          );
+          this.activeStreamContexts.delete(agentOSStreamId);
+          await this.dependencies.streamingManager.closeStream(agentOSStreamId, "GMI processing complete (final marker).");
         }
         break;
       case GMIOutputChunkType.USAGE_UPDATE:

src/cognitive_substrate/GMI.ts

@@ -328,7 +328,7 @@ export class GMI implements IGMI {
       case GMIInteractionType.MULTIMODAL_CONTENT:
         messageToAdd = { role: 'user', content: turnInput.content as any, name: turnInput.metadata?.userName || turnInput.userId };
         break;
-      case GMIInteractionType.TOOL_RESPONSE:
+      case GMIInteractionType.TOOL_RESPONSE: {
         const results = Array.isArray(turnInput.content) ? turnInput.content as ToolCallResult[] : [turnInput.content as ToolCallResult];
         results.forEach(result => {
           this.conversationHistory.push({
@@ -339,6 +339,7 @@ export class GMI implements IGMI {
           });
         });
         break;
+      }
       case GMIInteractionType.SYSTEM_MESSAGE:
         messageToAdd = { role: 'system', content: turnInput.content as string };
         break;

src/core/agents/AgentPoolAgent.ts

@@ -288,7 +288,7 @@ export class AgentPoolAgent extends AgentCore implements IAgent {
           return await this.handleDirectDelegation(userInput, conversationContext);
         case AgentPoolStrategy.EXPLORATORY_GENERATION:
           return await this.handleExploratoryGeneration(userInput, conversationContext);
-        default:
+        default: {
           const errorMsg = `AgentPoolAgent '${this.name}': Unhandled or unknown strategy '${this.poolConfig.strategy}'.`;
           console.error(errorMsg);
           // Use the inherited error handler to explain this to the user via LLM
@@ -297,6 +297,7 @@ export class AgentPoolAgent extends AgentCore implements IAgent {
             conversationContext,
             true // This is fatal for the turn
           );
+        }
       }
     } catch (error: any) {
         const strategyErrorMsg = `Error executing strategy '${this.poolConfig.strategy}' in AgentPoolAgent '${this.name}': ${error.message}`;

src/core/audio/AdaptiveVAD.ts

@@ -85,12 +85,6 @@ export interface AdaptiveVADConfig {
   // spectralConfig?: { zcrThreshold?: number; fluxThreshold?: number; };
 }
 
-// Declare emit and on methods more strongly for typed events
-export declare interface AdaptiveVAD {
-  on<U extends keyof VADEmitterEvents>(event: U, listener: VADEmitterEvents[U]): this;
-  emit<U extends keyof VADEmitterEvents>(event: U, ...args: Parameters<VADEmitterEvents[U]>): boolean;
-}
-
 /**
  * AdaptiveVAD - Detects speech in audio frames, adapting to environmental noise.
  */
@@ -117,6 +111,15 @@ export class AdaptiveVAD extends EventEmitter {
 
   private energyHistory: number[] = []; // For smoothing
 
+  // Strongly typed event helpers
+  public override on<U extends keyof VADEmitterEvents>(event: U, listener: VADEmitterEvents[U]): this {
+    return super.on(event, listener);
+  }
+
+  public override emit<U extends keyof VADEmitterEvents>(event: U, ...args: Parameters<VADEmitterEvents[U]>): boolean {
+    return super.emit(event, ...args);
+  }
+
   /**
    * Creates a new AdaptiveVAD instance.
    * @param {AdaptiveVADConfig} config - VAD configuration options.

src/core/audio/AudioProcessor.ts

@@ -76,11 +76,6 @@ export interface WebAudioProcessorEvents extends VADEmitterEvents {
   'raw_audio_frame': (frame: Float32Array, sampleRate: number) => void;
 }
 
-export declare interface AudioProcessor {
-  on<U extends keyof WebAudioProcessorEvents>(event: U, listener: WebAudioProcessorEvents[U]): this;
-  emit<U extends keyof WebAudioProcessorEvents>(event: U, ...args: Parameters<WebAudioProcessorEvents[U]>): boolean;
-}
-
 /**
  * AudioProcessor - Central client-side audio processing pipeline using Web Audio APIs.
  * Orchestrates EnvironmentalCalibrator (web-version) and AdaptiveVAD (logic-version).
@@ -105,6 +100,14 @@ export class AudioProcessor extends EventEmitter {
 
   private internalState: AudioProcessorState;
 
+  public override on<U extends keyof WebAudioProcessorEvents>(event: U, listener: WebAudioProcessorEvents[U]): this {
+    return super.on(event, listener);
+  }
+
+  public override emit<U extends keyof WebAudioProcessorEvents>(event: U, ...args: Parameters<WebAudioProcessorEvents[U]>): boolean {
+    return super.emit(event, ...args);
+  }
+
   constructor(
     config: WebAudioProcessorConfig = {},
     calibrationConfig: CalibrationConfig = {}, // For web-based EnvironmentalCalibrator