Skip to content

Commit d301f1a

Browse files
committed
fix(tour): drop scrim + click-away — tour now never blocks page
1 parent 61599b2 commit d301f1a

1 file changed

Lines changed: 6 additions & 25 deletions

File tree

src/dashboard/src/components/tour/GuidedTour.tsx

Lines changed: 6 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -386,31 +386,12 @@ export function GuidedTour({ activeTab, chatEnabled = true, onTabChange, onClose
386386

387387
return (
388388
<>
389-
{/* Dim overlay with cutout around highlighted element. Painted
390-
* only when a `rect` is measured — without that gate the scrim
391-
* renders solid dim with no hole (no target found / wrong tab),
392-
* which is what the user saw as "full-page dim with no tour info"
393-
* after navigating to a tab the current step doesn't target. */}
394-
{rect && (
395-
<div data-tour-overlay className={styles.svgOverlay}>
396-
<svg width="100%" height="100%" className={styles.svgFill}>
397-
<defs>
398-
<mask id="tour-mask">
399-
<rect width="100%" height="100%" fill="white" />
400-
<rect
401-
x={rect.left - pad} y={rect.top - pad}
402-
width={rect.width + pad * 2} height={rect.height + pad * 2}
403-
rx="10" fill="black"
404-
/>
405-
</mask>
406-
</defs>
407-
<rect width="100%" height="100%" fill="rgba(0,0,0,0.18)" mask="url(#tour-mask)" />
408-
</svg>
409-
</div>
410-
)}
411-
412-
{/* Click-away layer */}
413-
<div data-tour-overlay className={styles.clickAway} onClick={handleClose} />
389+
{/* Scrimless tour per the file header intent — no SVG dim overlay,
390+
* no full-viewport click-away. The pulsing amber outline on the
391+
* highlighted element carries the focus signal; the tour card
392+
* itself stays interactive with X / ESC / arrow keys for
393+
* dismissal and navigation. The full page stays clickable
394+
* underneath, so navigating away mid-tour just works. */}
414395

415396
{/* Tour card */}
416397
<div data-tour-overlay className={cardCls} style={cardVars} onClick={e => e.stopPropagation()} role="dialog" aria-label="Guided tour">

0 commit comments

Comments
 (0)