perf: reduce overhead on requested uri and eTag generation

Author: francescovallone

packages/serinus/lib/src/contexts/route_context.dart

@@ -42,10 +42,7 @@ class RouteContext<T extends RouteHandlerSpec> {
   final ModuleScope moduleScope;
 
   /// The [providers] property contains the providers of the module.
-  late final Map<Type, Provider> providers = {
-    for (var provider in moduleScope.unifiedProviders)
-      provider.runtimeType: provider,
-  };
+  Map<Type, Provider> providers = {};
 
   /// The [values] property contains the values from ValueProviders.
   late final Map<ValueToken, Object?> values = Map.unmodifiable(
@@ -125,7 +122,12 @@ class RouteContext<T extends RouteHandlerSpec> {
     this.queryParameters = const {},
     this.hooksServices = const {},
     this.exceptionFilters = const {},
-  });
+  }) {
+    providers = {
+      for (var provider in moduleScope.unifiedProviders)
+        provider.runtimeType: provider,
+    };
+  }
 
   /// Initializes the metadata for the route context.
   Future<Map<String, Metadata>> initMetadata(ExecutionContext context) async {

packages/serinus/lib/src/core/middlewares/middleware.dart

@@ -94,7 +94,7 @@ class _ShelfMiddleware extends Middleware {
     }
     return shelf.Request(
       argsHost.request.method.toString(),
-      argsHost.request.uri,
+      argsHost.request.requestedUri,
       body: argsHost.request.body.toString(),
       headers: Map<String, Object>.from(argsHost.request.headers.values),
       context: {'shelf.io.connection_info': argsHost.request.clientInfo!},

packages/serinus/lib/src/exceptions/serinus_exception.dart

@@ -1,5 +1,4 @@
 import 'dart:io';
-import 'dart:typed_data';
 
 import '../extensions/string_extensions.dart';
 import '../mixins/mixins.dart';
@@ -40,7 +39,7 @@ class SerinusException with JsonObject implements HttpException {
   @override
   Map<String, dynamic> toJson() {
     return {
-      'message': Uint8List.fromList(message.codeUnits).tryParse() ?? message,
+      'message': message.codeUnits.tryParse() ?? message,
       'statusCode': statusCode,
       'uri': uri != null ? uri!.path : 'No Uri',
     };

packages/serinus/lib/src/extensions/string_extensions.dart

@@ -1,11 +1,10 @@
 import 'dart:convert';
-import 'dart:typed_data';
 
 /// The [jsonDecoder] is used to decode JSON strings.
 final jsonDecoder = Utf8Decoder().fuse(const JsonDecoder());
 
 /// The extension [JsonString] is used to add functionalities to the [String] class.
-extension JsonString on Uint8List {
+extension JsonString on List<int> {
   /// This method is used to parse a [String] to a [Map<String, dynamic>].
   dynamic tryParse() {
     try {

packages/serinus/lib/src/http/internal_request.dart

@@ -36,6 +36,9 @@ abstract class IncomingMessage {
   /// The uri of the request.
   Uri get uri;
 
+  /// The requested uri of the request. It is the absolute and complete uri of the request.
+  Uri get requestedUri;
+
   /// The method of the request.
   String get method;
 
@@ -163,11 +166,14 @@ class InternalRequest extends IncomingMessage {
   String get id => _id ??= 'req-${original.hashCode ^ ++_idCounter}';
 
   // Cache the parsed URI to avoid repeated Uri.parse work on hot paths.
-  late final Uri _uri = original.requestedUri;
+  late final Uri _uri = original.uri;
 
   @override
   String get path => _uri.path;
 
+  @override
+  Uri get requestedUri => original.requestedUri;
+
   @override
   Uri get uri => _uri;
 

packages/serinus/lib/src/http/request.dart

@@ -36,9 +36,12 @@ class Request {
   /// The path of the request.
   String get path => _original.path;
 
-  /// The uri of the request.
+  /// The uri of the request. It is the path of the request as received in the HTTP line.
   Uri get uri => _original.uri;
 
+  /// The requested uri of the request. It is the absolute and complete uri of the request.
+  Uri get requestedUri => _original.requestedUri;
+
   /// The method of the request.
   HttpMethod get method => HttpMethod.parse(_original.method);
 

packages/serinus/lib/src/utils/wrapped_response.dart

@@ -2,8 +2,6 @@ import 'dart:convert';
 import 'dart:io';
 import 'dart:typed_data';
 
-import 'package:crypto/crypto.dart';
-
 import '../extensions/object_extensions.dart';
 
 /// Shared JSON encoder to avoid repeated allocations.
@@ -14,11 +12,14 @@ class WrappedResponse {
   /// The wrapped data.
   Object? _data;
 
+  List<int>? _encodedBytes;
+
   /// Get the wrapped data.
   Object? get data => _data;
 
   set data(Object? value) {
     _data = value;
+    _encodedBytes = null;
     isEncoded = false;
   }
 
@@ -30,39 +31,54 @@ class WrappedResponse {
 
   /// Convert the data to bytes.
   List<int> toBytes() {
+    final encodedBytes = _encodedBytes;
+    if (encodedBytes != null) {
+      return encodedBytes;
+    }
     if (data == null) {
-      return Uint8List(0);
+      return _encodedBytes = Uint8List(0);
     }
     if (isEncoded && data is List<int>) {
-      return data as List<int>;
+      return _encodedBytes = data as List<int>;
     }
     if (data is Uint8List) {
-      return data as Uint8List;
+      return _encodedBytes = data as Uint8List;
     }
     // Primitive types
     if (data is String || data is num || data is bool) {
-      return data?.toBytes() ?? Uint8List(0);
+      return _encodedBytes = data?.toBytes() ?? Uint8List(0);
     }
     // File
     if (data is File) {
-      return (data as File).readAsBytesSync();
+      return _encodedBytes = (data as File).readAsBytesSync();
     }
     // If data was JSON-serializable but wasn't encoded earlier, fall back to encoding here.
     if (data!.canBeJson()) {
-      return sharedJsonUtf8Encoder.convert(data);
+      return _encodedBytes = sharedJsonUtf8Encoder.convert(data);
     }
     // Fallback: string representation
-    return utf8.encode(data.toString()) as Uint8List? ?? Uint8List(0);
+    return _encodedBytes = utf8.encode(data.toString());
   }
 
   /// Get the ETag for the response data.
   String get eTag {
     final bytes = toBytes();
     if (bytes.isEmpty) {
-      return '"0-2jmj7l5rSw0yVb/vlWAYkK/YBwk"'; // ETag for empty response
+      return 'W/"0-0"';
+    }
+    final hash = _fastHash(bytes);
+    return 'W/"${bytes.length.toRadixString(16)}-${hash.toRadixString(16)}"';
+  }
+
+  int _fastHash(List<int> bytes) {
+    const int offsetBasis = 0x811c9dc5;
+    const int fnvPrime = 0x01000193;
+
+    var hash = offsetBasis;
+    for (final byte in bytes) {
+      hash ^= byte;
+      hash = (hash * fnvPrime) & 0xffffffff;
     }
-    // Simple ETag generation using a hash of the bytes
-    final hash = base64Encode(sha1.convert(bytes).bytes).substring(0, 27);
-    return '"${bytes.length}-$hash"';
+    return hash;
   }
 }

packages/serinus_microservices/lib/transporters/grpc/grpc_transport.dart

@@ -84,7 +84,7 @@ class GrpcTransport extends TransportAdapter<Server, GrpcOptions> {
 
   @override
   Future<void> init(ApplicationConfig config) async {
-    _messagesResolver = GrpcMessageResolver(
+    messagesResolver = GrpcMessageResolver(
       config,
       (services) {
         server = Server.create(
@@ -171,9 +171,4 @@ class GrpcTransport extends TransportAdapter<Server, GrpcOptions> {
         });
     return controller.stream;
   }
-
-  MessagesResolver? _messagesResolver;
-
-  @override
-  MessagesResolver? get messagesResolver => _messagesResolver;
 }