Skip to content

Commit 4940c3a

Browse files
committed
Fix tests
1 parent 1c5f3ca commit 4940c3a

File tree

4 files changed

+37
-11
lines changed

4 files changed

+37
-11
lines changed

tests/Functional/Controller/ImagineControllerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ protected function setUp(): void
3535
// supported by the current PHP build or not. Enabling WebP in configurations will drop all tests if WebP is
3636
// not supported.
3737
if ($this->webp_generate) {
38-
$filterService = self::getService('liip_imagine.service.filter');
38+
$filterService = self::getService('test.liip_imagine.service.filter');
3939
$webpGenerate = new \ReflectionProperty($filterService, 'webpGenerate');
4040
$webpGenerate->setAccessible(true);
4141
$webpGenerate->setValue($filterService, true);

tests/Functional/app/AppKernel.php

Lines changed: 34 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,18 @@
1111

1212
namespace Liip\ImagineBundle\Tests\Functional\app;
1313

14+
use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
1415
use Symfony\Component\Config\Loader\LoaderInterface;
16+
use Symfony\Component\DependencyInjection\ContainerBuilder;
17+
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
1518
use Symfony\Component\HttpKernel\Kernel;
19+
use Symfony\Component\Routing\Loader\Configurator\RouteConfigurator;
20+
use Symfony\Component\Routing\RouteCollectionBuilder;
1621

1722
class AppKernel extends Kernel
1823
{
24+
use MicroKernelTrait;
25+
1926
public function registerBundles(): iterable
2027
{
2128
$bundles = [
@@ -44,15 +51,37 @@ public function getProjectDir(): string
4451
}
4552

4653
/**
47-
* @throws \Exception
54+
* @param RouteCollectionBuilder|RouteConfigurator $routes
55+
*/
56+
protected function configureRoutes($routes): void
57+
{
58+
$routes->import($this->getProjectDir().'/config/routing.yml');
59+
}
60+
61+
/**
62+
* @param ContainerBuilder|ContainerConfigurator $containerBuilder
4863
*/
49-
public function registerContainerConfiguration(LoaderInterface $loader): void
64+
protected function configureContainer($containerBuilder, LoaderInterface $loader): void
5065
{
5166
if (version_compare(self::VERSION, '5.3', '>=')) {
52-
$loader->load(__DIR__.'/config/symfony_5-3.yaml');
67+
$loader->load($this->getProjectDir().'/config/symfony_5-3.yaml');
68+
} else {
69+
$loader->load($this->getProjectDir().'/config/symfony_legacy.yaml');
70+
}
71+
72+
$loader->load($this->getProjectDir().'/config/config.yml');
73+
74+
if ($containerBuilder instanceof ContainerBuilder) {
75+
$containerBuilder
76+
->setAlias('test.liip_imagine.service.filter', 'liip_imagine.service.filter')
77+
->setPublic(true);
78+
$containerBuilder
79+
->setAlias('test.liip_imagine.filter.manager', 'liip_imagine.filter.manager')
80+
->setPublic(true);
5381
} else {
54-
$loader->load(__DIR__.'/config/symfony_legacy.yaml');
82+
$containerBuilder->services()
83+
->alias('test.liip_imagine.service.filter', 'liip_imagine.service.filter')->public()
84+
->alias('test.liip_imagine.filter.manager', 'liip_imagine.filter.manager')->public();
5585
}
56-
$loader->load(__DIR__.'/config/config.yml');
5786
}
5887
}

tests/Functional/app/config/config.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ framework:
1313
default_locale: "%locale%"
1414
test: ~
1515

16-
router:
17-
resource: "%kernel.project_dir%/config/routing.yml"
18-
1916
liip_imagine:
2017

2118
controller:

tests/Message/Handler/WarmupCacheHandlerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,14 @@ public function testThrowIfMessageMissingPath(): void
7474
*/
7575
private function createFilterManagerMock()
7676
{
77-
return $this->getService('liip_imagine.filter.manager');
77+
return $this->getService('test.liip_imagine.filter.manager');
7878
}
7979

8080
/**
8181
* @return object|FilterService
8282
*/
8383
private function createFilterServiceMock()
8484
{
85-
return $this->getService('liip_imagine.service.filter');
85+
return $this->getService('test.liip_imagine.service.filter');
8686
}
8787
}

0 commit comments

Comments
 (0)