Skip to content

Commit 816fd90

Browse files
Merge pull request #284 from frappe/mergify/bp/master/pr-283
chore(archive): Drop assets when moving to archives directory (backport #283)
2 parents 1a2a95c + de04ee9 commit 816fd90

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

agent/server.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,13 +155,13 @@ def unused_image_size(self) -> list[float]:
155155
images_present = [image.split() for image in images_present]
156156
images_in_use = self.execute("docker container ls --format {{.Image}}")["output"].split("\n")
157157

158-
return [
159-
to_bytes(size) for image_name, size in images_present if image_name not in images_in_use
160-
]
158+
return [to_bytes(size) for image_name, size in images_present if image_name not in images_in_use]
161159

162160
def get_reclaimable_size(self) -> dict[str, dict[str, float] | float]:
163161
"""Checks archived and unused docker artefacts size"""
164-
archived_folder_size = self.execute("du -sB1 /home/frappe/archived/ | awk '{print $1}'").get("output")
162+
archived_folder_size = self.execute(
163+
"du -sB1 /home/frappe/archived/ --exclude assets | awk '{print $1}'"
164+
).get("output")
165165
unused_images_size = sum(self.unused_image_size())
166166

167167
formatted_archived_folder_size = f"{round(float(archived_folder_size) / 1024**3, 2)}GB"
@@ -277,6 +277,12 @@ def move_bench_to_archived_directory(self, bench_name):
277277
if os.path.exists(target):
278278
shutil.rmtree(target)
279279
bench_directory = os.path.join(self.benches_directory, bench_name)
280+
assets_directory = os.path.join(bench_directory, "sites", "assets")
281+
282+
# Dropping assets we don't restore that anyways
283+
if os.path.exists(assets_directory):
284+
shutil.rmtree(assets_directory)
285+
280286
self.execute(f"mv {bench_directory} {self.archived_directory}")
281287

282288
@job("Update Site Pull", priority="low")

0 commit comments

Comments
 (0)