Skip to content

Commit 2572e31

Browse files
committed
chore: bump to 1.5.2 🎉
1 parent 222cbb6 commit 2572e31

13 files changed

+42
-11
lines changed

dist/frappe-charts.esm.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,19 @@ function getPositionByAngle(angle, radius) {
364364
};
365365
}
366366

367+
/**
368+
* Check if a number is valid for svg attributes
369+
* @param {object} candidate Candidate to test
370+
* @param {Boolean} nonNegative flag to treat negative number as invalid
371+
*/
372+
function isValidNumber(candidate, nonNegative=false) {
373+
if (Number.isNaN(candidate)) return false;
374+
else if (candidate === undefined) return false;
375+
else if (!Number.isFinite(candidate)) return false;
376+
else if (nonNegative && candidate < 0) return false;
377+
else return true;
378+
}
379+
367380
function getBarHeightAndYAttr(yTop, zeroLine) {
368381
let height, y;
369382
if (yTop <= zeroLine) {
@@ -864,6 +877,8 @@ function makeHoriLine(y, label, x1, x2, options={}) {
864877
}
865878

866879
function yLine(y, label, width, options={}) {
880+
if (!isValidNumber(y)) y = 0;
881+
867882
if(!options.pos) options.pos = 'left';
868883
if(!options.offset) options.offset = 0;
869884
if(!options.mode) options.mode = 'span';
@@ -892,6 +907,8 @@ function yLine(y, label, width, options={}) {
892907
}
893908

894909
function xLine(x, label, height, options={}) {
910+
if (!isValidNumber(x)) x = 0;
911+
895912
if(!options.pos) options.pos = 'bottom';
896913
if(!options.offset) options.offset = 0;
897914
if(!options.mode) options.mode = 'span';
@@ -1002,6 +1019,12 @@ function datasetBar(x, yTop, width, color, label='', index=0, offset=0, meta={})
10021019
y -= meta.minHeight;
10031020
}
10041021

1022+
// Preprocess numbers to avoid svg building errors
1023+
if (!isValidNumber(x)) x = 0;
1024+
if (!isValidNumber(y)) y = 0;
1025+
if (!isValidNumber(height, true)) height = 0;
1026+
if (!isValidNumber(width, true)) width = 0;
1027+
10051028
let rect = createSVG('rect', {
10061029
className: `bar mini`,
10071030
style: `fill: ${color}`,

dist/frappe-charts.min.cjs.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/frappe-charts.min.cjs.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/frappe-charts.min.esm.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/frappe-charts.min.esm.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/frappe-charts.min.iife.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/frappe-charts.min.iife.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/assets/js/frappe-charts.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/assets/js/frappe-charts.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/assets/js/index.min.js

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)