Skip to content

Commit 14d9b3e

Browse files
committed
fix: do not override field.options meta
1 parent 625ccf4 commit 14d9b3e

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

Diff for: crm/api/doc.py

+8-7
Original file line numberDiff line numberDiff line change
@@ -181,16 +181,17 @@ def get_quick_filters(doctype: str):
181181
quick_filters = []
182182

183183
for field in fields:
184-
if field.fieldtype == "Select":
185-
field.options = field.options.split("\n")
186-
field.options = [{"label": option, "value": option} for option in field.options]
187-
field.options.insert(0, {"label": "", "value": ""})
184+
options = field.options
185+
if field.fieldtype == "Select" and options and isinstance(options, str):
186+
options = options.split("\n")
187+
options = [{"label": option, "value": option} for option in options]
188+
options.insert(0, {"label": "", "value": ""})
188189
quick_filters.append(
189190
{
190191
"label": _(field.label),
191192
"name": field.fieldname,
192193
"type": field.fieldtype,
193-
"options": field.options,
194+
"options": options,
194195
}
195196
)
196197

@@ -278,7 +279,7 @@ def get_data(
278279
columns = frappe.parse_json(list_view_settings.columns)
279280
rows = frappe.parse_json(list_view_settings.rows)
280281
is_default = False
281-
elif not custom_view or is_default and hasattr(_list, "default_list_data"):
282+
elif not custom_view or (is_default and hasattr(_list, "default_list_data")):
282283
rows = default_rows
283284
columns = _list.default_list_data().get("columns")
284285

@@ -341,7 +342,7 @@ def get_data(
341342
for kc in kanban_columns:
342343
column_filters = {column_field: kc.get("name")}
343344
order = kc.get("order")
344-
if column_field in filters and filters.get(column_field) != kc.name or kc.get("delete"):
345+
if (column_field in filters and filters.get(column_field) != kc.name) or kc.get("delete"):
345346
column_data = []
346347
else:
347348
column_filters.update(filters.copy())

0 commit comments

Comments
 (0)