Skip to content

Commit ee67d7f

Browse files
committed
fix(HoverCard): drop duplicate update:open emit declaration
defineModel('open') already registers the update:open emit, so the separate defineEmits<HoverCardEmits>() declared it twice and triggered a Vue dev-mode duplicate-emit warning. Let defineModel own the emit and remove the now-unused HoverCardEmits type and its re-export.
1 parent 96988a5 commit ee67d7f

3 files changed

Lines changed: 2 additions & 8 deletions

File tree

src/components/HoverCard/HoverCard.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
} from 'reka-ui'
99
import { computed } from 'vue'
1010
import PopoverPanel from '../shared/popover/PopoverPanel.vue'
11-
import type { HoverCardProps, HoverCardEmits } from './types'
11+
import type { HoverCardProps } from './types'
1212
1313
defineOptions({
1414
inheritAttrs: false,
@@ -25,8 +25,6 @@ const props = withDefaults(defineProps<HoverCardProps>(), {
2525
arrow: false,
2626
})
2727
28-
defineEmits<HoverCardEmits>()
29-
3028
const open = defineModel<boolean>('open', { default: false })
3129
3230
// reka HoverCard delays are in milliseconds; the public API uses seconds to

src/components/HoverCard/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
export { default as HoverCard } from './HoverCard.vue'
2-
export type { HoverCardProps, HoverCardEmits } from './types'
2+
export type { HoverCardProps } from './types'

src/components/HoverCard/types.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,3 @@ export interface HoverCardProps {
4545
*/
4646
arrow?: boolean
4747
}
48-
49-
export type HoverCardEmits = {
50-
'update:open': [value: boolean]
51-
}

0 commit comments

Comments
 (0)