Skip to content

Commit 889435e

Browse files
ishanloyanextchamp-saqib
authored andcommitted
refactor: remove sass dependency (#752)
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> (cherry picked from commit 8aaa08e)
1 parent b7f96cf commit 889435e

File tree

11 files changed

+30
-166
lines changed

11 files changed

+30
-166
lines changed

frontend/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
"patch-package": "^8.0.1",
5353
"postcss": "^8.4.14",
5454
"prettier": "3.1.0",
55-
"sass": "^1.54.9",
5655
"tailwindcss": "3.4.17",
5756
"typescript": "^5.5.2",
5857
"vite": "^4.4.6",

frontend/src/components/ContentEditable.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ watch(
121121
)
122122
</script>
123123
124-
<style lang="scss">
124+
<style>
125125
.contenteditable:empty:before {
126126
content: attr(placeholder);
127127
pointer-events: none;

frontend/src/dashboard/VueGridLayout.vue

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ async function toggleEnable(disable) {
5858
watch(() => props.disabled, toggleEnable, 200)
5959
</script>
6060

61-
<style lang="scss">
61+
<style>
6262
.vgl-layout {
6363
--vgl-placeholder-bg: #b1b1b1;
6464
--vgl-placeholder-opacity: 20%;
@@ -91,14 +91,14 @@ watch(() => props.disabled, toggleEnable, 200)
9191
width: var(--vgl-resizer-size);
9292
height: var(--vgl-resizer-size);
9393
cursor: se-resize;
94-
}
9594
96-
.vgl-item__resizer:before {
97-
position: absolute;
98-
inset: 0 3px 3px 0;
99-
content: '';
100-
border: 0 solid var(--vgl-resizer-border-color);
101-
border-right-width: var(--vgl-resizer-border-width);
102-
border-bottom-width: var(--vgl-resizer-border-width);
95+
&:before {
96+
position: absolute;
97+
inset: 0 3px 3px 0;
98+
content: '';
99+
border: 0 solid var(--vgl-resizer-border-color);
100+
border-right-width: var(--vgl-resizer-border-width);
101+
border-bottom-width: var(--vgl-resizer-border-width);
102+
}
103103
}
104104
</style>

frontend/src/notebook/tiptap/TipTap.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const bubbleMenu = [
8484
]
8585
</script>
8686

87-
<style lang="scss">
87+
<style>
8888
/* Placeholder */
8989
.prose [data-placeholder].is-empty::before {
9090
content: attr(data-placeholder);

frontend/src/widgets/Text/Text.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const dashboard = inject('dashboard')
2525
</template>
2626
</template>
2727

28-
<style lang="scss">
28+
<style>
2929
.prose-sm {
3030
& > h1,
3131
& > h2,

frontend/src2/charts/components/NewMeasureSelectorDialog.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,18 +141,18 @@ function resetNewMeasure() {
141141
</Dialog>
142142
</template>
143143

144-
<style lang="scss">
144+
<style>
145145
div[data-dismissable-layer] {
146146
border-radius: 0.75rem;
147147
}
148148
.column-expression {
149-
.cm-column-highlight {
149+
& .cm-column-highlight {
150150
background-color: #ededed !important;
151151
border-radius: 0.5rem !important;
152152
padding: 1px 2px !important;
153153
border: 1px solid #dedede !important;
154154
}
155-
.cm-scroller {
155+
& .cm-scroller {
156156
background-color: #ffffff !important;
157157
border-radius: 0.5rem !important;
158158
border: 1px solid #ededed !important;

frontend/src2/components/ContentEditable.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ watch(
131131
)
132132
</script>
133133
134-
<style lang="scss">
134+
<style>
135135
.contenteditable:empty:before {
136136
content: attr(placeholder);
137137
pointer-events: none;

frontend/src2/dashboard/VueGridLayout.vue

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const options = reactive({
7272
})
7373
</script>
7474

75-
<style lang="scss">
75+
<style>
7676
.vgl-layout {
7777
--vgl-placeholder-bg: #b1b1b1;
7878
--vgl-placeholder-opacity: 15%;
@@ -105,14 +105,14 @@ const options = reactive({
105105
width: var(--vgl-resizer-size);
106106
height: var(--vgl-resizer-size);
107107
cursor: se-resize;
108-
}
109108
110-
.vgl-item__resizer:before {
111-
position: absolute;
112-
inset: 0 3px 3px 0;
113-
content: '';
114-
border: 0 solid var(--vgl-resizer-border-color);
115-
border-right-width: var(--vgl-resizer-border-width);
116-
border-bottom-width: var(--vgl-resizer-border-width);
109+
&:before {
110+
position: absolute;
111+
inset: 0 3px 3px 0;
112+
content: '';
113+
border: 0 solid var(--vgl-resizer-border-color);
114+
border-right-width: var(--vgl-resizer-border-width);
115+
border-bottom-width: var(--vgl-resizer-border-width);
116+
}
117117
}
118118
</style>

frontend/src2/query/components/ExpressionEditor.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -315,15 +315,15 @@ function setSignatureElementPosition() {
315315
</div> -->
316316
</template>
317317

318-
<style lang="scss">
318+
<style>
319319
.column-expression {
320-
.cm-content {
320+
& .cm-content {
321321
height: 100% !important;
322322
}
323-
.cm-gutters {
323+
& .cm-gutters {
324324
height: 100% !important;
325325
}
326-
.cm-tooltip-autocomplete {
326+
& .cm-tooltip-autocomplete {
327327
position: absolute !important;
328328
z-index: 50 !important;
329329
}

frontend/vite.config.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,6 @@ export default defineConfig({
1919
allowedHosts: true,
2020
},
2121
esbuild: { loader: 'ts' },
22-
css: {
23-
preprocessorOptions: {
24-
scss: {
25-
api: 'modern-compiler', // or "modern"
26-
silenceDeprecations: ['legacy-js-api'],
27-
},
28-
},
29-
},
3022
resolve: {
3123
alias: {
3224
// https://github.com/vitejs/vite/discussions/16730#discussioncomment-13048825

0 commit comments

Comments
 (0)