From c828b132ab80d7f6febbc04b5adbbf0ba7b75480 Mon Sep 17 00:00:00 2001
From: Saqib Ansari <nextchamp.saqib@gmail.com>
Date: Sun, 29 Mar 2026 21:43:32 +0530
Subject: [PATCH] feat: support JSON and JSONL file uploads (#1012)

(cherry picked from commit 41d390d05ebbfa9636f6d25a8b3974990b9f3d97)
---
 frontend/src2/data_source/UploadCSVFileDialog.vue    |  6 +++---
 frontend/src2/query/components/QueryBuilderTable.vue |  1 +
 insights/api/__init__.py                             | 12 ++++++++++--
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/frontend/src2/data_source/UploadCSVFileDialog.vue b/frontend/src2/data_source/UploadCSVFileDialog.vue
index b7ae4f0e4..fa0111116 100644
--- a/frontend/src2/data_source/UploadCSVFileDialog.vue
+++ b/frontend/src2/data_source/UploadCSVFileDialog.vue
@@ -93,7 +93,7 @@ function resetFile() {
 	<Dialog
 		v-model="show"
 		:options="{
-			title: csvData.tablename ? __('Import Table') : __('Upload CSV/Excel File'),
+			title: csvData.tablename ? __('Import Table') : __('Upload CSV/Excel/JSON File'),
 			size: fileUploaded ? '4xl' : '',
 		}"
 	>
@@ -101,7 +101,7 @@ function resetFile() {
 			<FileUploader
 				v-if="!fileUploaded"
 				:uploadArgs="{ private: true }"
-				:file-types="['.csv', '.xlsx']"
+				:file-types="['.csv', '.xlsx', '.json', '.jsonl']"
 				@success="uploadFile"
 			>
 				<template #default="{ progress, uploading, openFileSelector }">
@@ -116,7 +116,7 @@ function resetFile() {
 						/>
 						<div class="text-center">
 							<p v-if="!uploading" class="text-sm font-medium text-gray-800">
-								Select a CSV or Excel file to upload
+								Select a CSV, Excel, or JSON file to upload
 							</p>
 							<p v-if="!uploading" class="mt-1 text-xs text-gray-600">
 								or drag and drop it here
diff --git a/frontend/src2/query/components/QueryBuilderTable.vue b/frontend/src2/query/components/QueryBuilderTable.vue
index a6eed9345..e60f00917 100644
--- a/frontend/src2/query/components/QueryBuilderTable.vue
+++ b/frontend/src2/query/components/QueryBuilderTable.vue
@@ -79,6 +79,7 @@ function addNewColumn() {
 			:enable-column-rename="true"
 			:enable-alerts="true"
 			:enable-new-column="true"
+			:enable-drill-down="true"
 		>
 			<template #header-prefix="{ column }">
 				<ColumnTypeChange
diff --git a/insights/api/__init__.py b/insights/api/__init__.py
index e68fa3925..e09535f16 100644
--- a/insights/api/__init__.py
+++ b/insights/api/__init__.py
@@ -91,9 +91,9 @@ def get_csv_file(filename: str):
     extension = parts[-1] if parts else ""
     extension = extension.lstrip(".")
 
-    if not extension or extension not in ["csv", "xlsx"]:
+    if not extension or extension not in ["csv", "xlsx", "json", "jsonl"]:
         frappe.throw(
-            f"Only CSV and XLSX files are supported. Detected extension: '{extension}' from filename: '{file_name}'"
+            f"Only CSV, XLSX, JSON, and JSONL files are supported. Detected extension: '{extension}' from filename: '{file_name}'"
         )
     return file, extension
 
@@ -128,6 +128,8 @@ def get_file_data(filename: str):
     try:
         if ext in ["xlsx"]:
             table = db.read_xlsx(file_path)
+        elif ext in ["json", "jsonl"]:
+            table = db.read_json(file_path)
         else:
             table = db.read_csv(file_path, table_name=file_name)
 
@@ -162,6 +164,8 @@ def import_csv_data(filename: str, tablename: str = ""):
     try:
         if ext in ["xlsx"]:
             table = db.read_xlsx(file_path)
+        elif ext in ["json", "jsonl"]:
+            table = db.read_json(file_path)
         else:
             table = db.read_csv(file_path, table_name=table_name)
         db.create_table(table_name, table, overwrite=True)
@@ -171,6 +175,10 @@ def import_csv_data(filename: str, tablename: str = ""):
             frappe.throw(
                 "Failed to read Excel data from uploaded file. Please ensure the file is a valid Excel format and try again."
             )
+        elif ext in ["json", "jsonl"]:
+            frappe.throw(
+                "Failed to read JSON data from uploaded file. Please ensure the file is a valid JSON or JSONL format and try again."
+            )
         else:
             frappe.throw("Failed to read CSV data from uploaded file. Please try again.")
     finally: