Merge pull request #2384 from frappe/mergify/bp/main/pr-2381

perf: refactor course outline and lesson to use qb (backport #2381)

Author: raizasafeel

frontend/src/components/CourseOutline.vue

@@ -228,9 +228,9 @@ const props = defineProps({
 		type: Boolean,
 		default: false,
 	},
-	lessonProgress: {
-		type: Number,
-		default: 0,
+	completedLesson: {
+		type: String,
+		default: null,
 	},
 })
 
@@ -254,9 +254,16 @@ watch(
 )
 
 watch(
-	() => props.lessonProgress,
-	() => {
-		outline.reload()
+	() => props.completedLesson,
+	(lessonName) => {
+		if (!lessonName || !outline.data) return
+		for (const chapter of outline.data) {
+			const found = chapter.lessons?.find((l) => l.name === lessonName)
+			if (found) {
+				found.is_complete = true
+				break
+			}
+		}
 	}
 )
 

frontend/src/pages/Lesson.vue

@@ -313,7 +313,7 @@
 					:courseName="courseName"
 					:key="chapterNumber"
 					:getProgress="lesson.data.membership ? true : false"
-					:lessonProgress="lessonProgress"
+					:completedLesson="completedLesson"
 				/>
 			</div>
 		</div>
@@ -405,6 +405,7 @@ const sidebarStore = useSidebar()
 const plyrSources = ref([])
 const showInlineMenu = ref(false)
 const currentTab = ref(null)
+const completedLesson = ref(null)
 let timerInterval = null
 
 const tabs = ref([])
@@ -545,6 +546,7 @@ const progress = createResource({
 	},
 	onSuccess(data) {
 		lessonProgress.value = data
+		completedLesson.value = lesson.data?.name
 	},
 })
 
@@ -782,11 +784,17 @@ onBeforeUnmount(() => {
 
 const checkIfDiscussionsAllowed = () => {
 	hasQuiz.value = false
-	JSON.parse(lesson.data?.content)?.blocks?.forEach((block) => {
-		if (block.type === 'quiz') {
-			hasQuiz.value = true
+	if (lesson.data?.content) {
+		try {
+			JSON.parse(lesson.data.content)?.blocks?.forEach((block) => {
+				if (block.type === 'quiz') {
+					hasQuiz.value = true
+				}
+			})
+		} catch {
+			// legacy markdown lessons
 		}
-	})
+	}
 
 	if (
 		!hasQuiz.value &&