Skip to content

Commit dc32579

Browse files
authored
Merge pull request #2414 from raizasafeel/fix/member-email
fix: drop member email from certified participants response
2 parents e93eb5e + 4703d4d commit dc32579

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

lms/lms/api.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,7 @@ def get_certified_participants(
417417
for participant in participants:
418418
details = get_certified_participant_details(participant.member)
419419
participant.update(details)
420+
participant.pop("member", None)
420421

421422
return participants
422423

lms/lms/test_api.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ def test_certified_participants_with_category(self):
2424
filters = {"category": "Utility Course"}
2525
certified_participants = get_certified_participants(filters=filters)
2626
self.assertEqual(len(certified_participants), 1)
27-
self.assertEqual(certified_participants[0].member, self.student1.email)
27+
self.assertEqual(certified_participants[0].full_name, self.student1.full_name)
28+
self.assertNotIn("member", certified_participants[0])
2829

2930
filters = {"category": "Nonexistent Category"}
3031
certified_participants_no_match = get_certified_participants(filters=filters)

0 commit comments

Comments
 (0)