Skip to content

Commit 40cf5bd

Browse files
committed
refactor: do fullscreen on body instead of container
1 parent 0bc171d commit 40cf5bd

4 files changed

Lines changed: 6 additions & 12 deletions

File tree

frontend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"@timephy/rnnoise-wasm": "^1.0.0",
1717
"emoji-mart": "^5.6.0",
1818
"feather-icons": "^4.29.2",
19-
"frappe-ui": "^0.1.269",
19+
"frappe-ui": "^0.1.271",
2020
"mediasoup-client": "^3.16.0",
2121
"reka-ui": "^2.6.0",
2222
"socket.io-client": "^4.7.2",

frontend/src/components/MeetingToolbar.vue

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@
154154
<Dropdown
155155
:options="moreOptions"
156156
placement="top"
157-
:portal-to="dropdownPortalTarget"
158157
>
159158
<template #default>
160159
<Button
@@ -299,9 +298,6 @@ const emit = defineEmits([
299298
300299
const { windowWidth } = useResponsiveGrid();
301300
const isMobile = computed(() => windowWidth.value < 768);
302-
const dropdownPortalTarget = computed(() =>
303-
props.isFullscreen ? "#meetingContainer" : "body",
304-
);
305301
306302
const moreOptions = computed(() => [
307303
{

frontend/src/pages/Meeting.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<template>
22
<div
3-
ref="meetingContainer"
43
class="h-[100dvh] bg-gray-900 flex flex-col"
54
data-meeting-component
65
id="meetingContainer"
@@ -363,7 +362,6 @@ const lobbyUsersForNotifications = computed(() => {
363362
// Refs
364363
const chatNotificationQueue = ref(null);
365364
const isReactionPickerOpen = ref(false);
366-
const meetingContainer = ref(null);
367365
const isFullscreen = ref(false);
368366
369367
// Methods
@@ -590,7 +588,7 @@ const syncFullscreenState = () => {
590588
const toggleFullscreen = async () => {
591589
try {
592590
if (!document.fullscreenElement) {
593-
const targetElement = meetingContainer.value;
591+
const targetElement = document.body;
594592
595593
if (targetElement?.requestFullscreen) {
596594
await targetElement.requestFullscreen();

frontend/yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1428,10 +1428,10 @@ fraction.js@^4.1.2:
14281428
resolved "https://registry.yarnpkg.com/fraction.js/-/fraction.js-4.1.2.tgz#13e420a92422b6cf244dff8690ed89401029fbe8"
14291429
integrity sha512-o2RiJQ6DZaR/5+Si0qJUIy637QMRudSi9kU/FFzx9EZazrIdnBgpU+3sEWCxAVhH2RtxW2Oz+T4p2o8uOPVcgA==
14301430

1431-
frappe-ui@^0.1.269:
1432-
version "0.1.269"
1433-
resolved "https://registry.yarnpkg.com/frappe-ui/-/frappe-ui-0.1.269.tgz#d694cd23fe6eadbd7bb898bb3f46e0414c27f829"
1434-
integrity sha512-1D4AW8cPoC7OIRqEzYnF169/r+v0EfVBvfCi/ovmk76FBPKY+qIVOzL+Vx/9TcYvJubc1tSU19F/jX177e3axA==
1431+
frappe-ui@^0.1.271:
1432+
version "0.1.271"
1433+
resolved "https://registry.yarnpkg.com/frappe-ui/-/frappe-ui-0.1.271.tgz#206aa52f4faa541da0cfdb2b32ae845e622b08e1"
1434+
integrity sha512-H6FDKLynUCXxo3eIainJd6FjWrBtAZ3WZXVRM4tvLT3J7x7P5JjoNefB6YD8WZ+MQThKSwMC+/Kzg8vY2mc5XQ==
14351435
dependencies:
14361436
"@floating-ui/dom" "^1.7.4"
14371437
"@floating-ui/vue" "^1.1.6"

0 commit comments

Comments
 (0)