fix(sfu): prevent repeated ICE restarts for same consumer stall

Author: BreadGenie

frontend/src/utils/media/__tests__/stallDetector.test.ts

@@ -112,7 +112,7 @@ describe("StallDetector", () => {
 		expect(det.check([toSample(sample)])).toEqual(["c1"]);
 	});
 
-	it("respects the per-consumer recovery cooldown", () => {
+	it("reports a stall once until media resumes", () => {
 		const det = detector();
 		const sample = makeSample({ createdAt: now - 10_000, muted: true });
 
@@ -125,6 +125,15 @@ describe("StallDetector", () => {
 		expect(det.check([toSample(sample)])).toEqual([]);
 
 		now += 30_000;
+		expect(det.check([toSample(sample)])).toEqual([]);
+
+		sample.muted = false;
+		sample.bytes = 2000;
+		expect(det.check([toSample(sample)])).toEqual([]);
+
+		sample.muted = true;
+		expect(det.check([toSample(sample)])).toEqual([]);
+		now += 6_000;
 		expect(det.check([toSample(sample)])).toEqual(["c1"]);
 	});
 

frontend/src/utils/media/stallDetector.ts

@@ -162,6 +162,13 @@ export class StallDetector {
 	}
 
 	private shouldRecover(st: ConsumerState, now: number): boolean {
+		if (
+			st.lastRecoveredAt !== null &&
+			st.stallStartedAt !== null &&
+			st.lastRecoveredAt >= st.stallStartedAt
+		) {
+			return false;
+		}
 		if (
 			st.lastRecoveredAt !== null &&
 			now - st.lastRecoveredAt < this.recoveryCooldownMs