Skip to content

Commit 7c8e2ff

Browse files
committed
refactor: cleanup code
1 parent 5ea2296 commit 7c8e2ff

2 files changed

Lines changed: 0 additions & 36 deletions

File tree

meet/api/meeting.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,6 @@ def refresh_sfu_token(meeting_id: str) -> dict:
245245
"""
246246
meeting: SaeMeeting = frappe.get_doc("Sae Meeting", meeting_id)
247247

248-
if not meeting.is_active:
249-
frappe.throw(_("Meeting has ended"))
250-
251248
if frappe.session.user not in meeting.get_members():
252249
frappe.throw(_("Not a meeting member"))
253250

meet/meet/doctype/sae_meeting/sae_meeting.py

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@ def autoname(self):
4040
if not self.name:
4141
self.name = generate()
4242

43-
def before_insert(self):
44-
"""Initialize meeting room"""
45-
if not hasattr(self, "is_active"):
46-
self.is_active = 1
47-
4843
def validate(self):
4944
"""Ensure unique users in all child tables"""
5045
self.members = unique_users(self.members) if self.members else []
@@ -84,26 +79,6 @@ def join(self, user=None):
8479

8580
return {"status": "joined", "message": "Successfully joined the meeting"}
8681

87-
def leave(self, user=None):
88-
"""
89-
Leave the meeting room
90-
91-
Args:
92-
user: User to remove (defaults to current session user)
93-
"""
94-
if not user:
95-
user = frappe.session.user
96-
97-
members = self.get_members()
98-
99-
if user in members:
100-
members.remove(user)
101-
self.update_members(members)
102-
103-
if not members:
104-
self.is_active = 0
105-
self.save(ignore_permissions=True)
106-
10782
def get_members(self):
10883
"""Get list of current members"""
10984
return [row.user for row in self.members] if self.members else []
@@ -128,14 +103,6 @@ def can_join(self, user=None):
128103
if self.is_user_banned(user):
129104
return False
130105

131-
# Check if meeting is active
132-
# if not self.get("is_active", True):
133-
# return False
134-
135-
# Check if user has read permission on the meeting
136-
# if not frappe.has_permission("Sae Meeting", "read", self):
137-
# return False
138-
139106
return True
140107

141108
def update_members(self, members_list):

0 commit comments

Comments
 (0)