Skip to content

Commit 1eac4ae

Browse files
authored
Merge pull request #6416 from frappe/fix/dashboard/notif_remove_perms
fix(api): Remove permission checks on notification
2 parents d7893bf + 55cc5b8 commit 1eac4ae

1 file changed

Lines changed: 0 additions & 17 deletions

File tree

press/api/notifications.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import frappe
22

3-
from press.guards import role_guard
4-
from press.guards.role_guard.document import has_user_permission
53
from press.utils import get_current_team
64

75

@@ -35,12 +33,6 @@ def get_notifications(
3533
.offset(limit_start)
3634
)
3735

38-
if role_guard.is_restricted():
39-
if not has_user_permission("Site"):
40-
query = apply_permission_filter(query, "Site", PressNotification)
41-
if not has_user_permission("Release Group"):
42-
query = apply_permission_filter(query, "Release Group", PressNotification)
43-
4436
if filters.get("read") == "Unread":
4537
query = query.where(PressNotification.read == 0)
4638

@@ -70,15 +62,6 @@ def assign_notification_route(notification):
7062
notification.route = None
7163

7264

73-
def apply_permission_filter(query, doctype, PressNotification):
74-
permitted = role_guard.permitted_documents(doctype)
75-
if not permitted:
76-
query = query.where(PressNotification.document_type != doctype)
77-
else:
78-
query = query.where(PressNotification.document_name.isin(permitted))
79-
return query
80-
81-
8265
@frappe.whitelist()
8366
def mark_all_notifications_as_read():
8467
frappe.db.set_value("Press Notification", {"team": get_current_team()}, "read", 1, update_modified=False)

0 commit comments

Comments
 (0)