Skip to content

Commit c8d8d2d

Browse files
authored
Merge pull request #6425 from tanmoysrt/fix_kv_access_in_job
fix(press-job): Workflow kv object doesn't support default
2 parents 0db67fe + 383bf6e commit c8d8d2d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

press/press/doctype/press_job/jobs/create_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,14 @@ def create_volume_from_snapshot(self):
118118
return
119119

120120
max_retries = self.arguments_dict.get("max_volume_creation_retries", 6)
121-
if self.kv.get("volume_creation_attempts", 0) >= max_retries:
121+
if (self.kv.get("volume_creation_attempts") or 0) >= max_retries:
122122
raise Exception(f"Failed to create volume from snapshot after {max_retries} retries")
123123

124124
is_created = self.virtual_machine_doc.create_data_disk_volume_from_snapshot()
125125
if is_created:
126126
return
127127

128-
self.kv.set("volume_creation_attempts", self.kv.get("volume_creation_attempts", 0) + 1)
128+
self.kv.set("volume_creation_attempts", self.kv.get("volume_creation_attempts") or 0 + 1)
129129
self.defer_current_task()
130130

131131
@task

0 commit comments

Comments
 (0)