Refactor GitHub Actions workflows for improved clarity and consistency

Author: frasermolyneux

.github/dependabot.yml

@@ -25,4 +25,4 @@ updates:
     assignees: ["frasermolyneux"]
     directory: "/"
     schedule:
-      interval: weekly
+      interval: "weekly"

.github/workflows/build-and-test.yml

@@ -20,3 +20,21 @@ jobs:
           dotnet-project: "XtremeIdiots.Portal.Repository.App"
           dotnet-version: 9.0.x
           src-folder: "src"
+
+  terraform-plan-dev:
+    permissions:
+      contents: read
+      id-token: write
+    runs-on: ubuntu-latest
+    environment: Development
+    concurrency:
+      group: ${{ github.repository }}-dev
+    steps:
+      - uses: frasermolyneux/actions/terraform-plan@main
+        with:
+          terraform-folder: "terraform"
+          terraform-var-file: "tfvars/dev.tfvars"
+          terraform-backend-file: "backends/dev.backend.hcl"
+          AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
+          AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
+          AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}

.github/workflows/deploy-prd.yml

@@ -1,15 +1,18 @@
-name: Deploy Prod
+name: Deploy Prd
 
 on:
-  workflow_dispatch:
-  schedule:
-    - cron: "0 3 * * 4"
   push:
     branches:
       - main
+  workflow_dispatch:
+  schedule:
+    - cron: "0 3 * * 4"
 
 permissions: {}
 
+concurrency:
+  group: ${{ github.workflow }}
+
 jobs:
   build-and-test:
     permissions:
@@ -135,6 +138,10 @@ jobs:
     runs-on: ubuntu-latest
     concurrency:
       group: ${{ github.repository }}-prd
+    if: |
+      always() &&
+      needs.terraform-plan-and-apply-prd.result == 'success' &&
+      (needs.function-app-deploy-dev.result == 'success' || needs.function-app-deploy-dev.result == 'skipped')
     steps:
       - uses: frasermolyneux/actions/deploy-function-app@main
         with:

.github/workflows/destroy-environment.yml

@@ -18,19 +18,17 @@ jobs:
   terraform-destroy:
     permissions:
       contents: read
-      id-token: write # This is required for Az CLI Login
+      id-token: write
     environment: ${{ inputs.environment == 'prd' && 'Production' || 'Development' }}
     runs-on: ubuntu-latest
-
-    concurrency: # Prevent multiple GitHub Actions invocations against stateful resources. e.g. Terraform state file / Database / Deployed Apps
+    concurrency:
       group: ${{ github.repository }}-${{ inputs.environment }}
-
     steps:
-    - uses: frasermolyneux/actions/terraform-destroy@main
-      with:
-        terraform-folder: "terraform"
-        terraform-var-file: ${{ inputs.environment == 'prd' && 'tfvars/prd.tfvars' || 'tfvars/dev.tfvars' }}
-        terraform-backend-file: ${{ inputs.environment == 'prd' && 'backends/prd.backend.hcl' || 'backends/dev.backend.hcl' }}
-        AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
-        AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
-        AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
+      - uses: frasermolyneux/actions/terraform-destroy@main
+        with:
+          terraform-folder: "terraform"
+          terraform-var-file: ${{ inputs.environment == 'prd' && 'tfvars/prd.tfvars' || 'tfvars/dev.tfvars' }}
+          terraform-backend-file: ${{ inputs.environment == 'prd' && 'backends/prd.backend.hcl' || 'backends/dev.backend.hcl' }}
+          AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
+          AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
+          AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}