Refactor code for consistency and clarity across various files

- Updated JSON property attributes in EditGameServerDto to use the correct JsonConverter.
- Simplified object creation in FakePlayersApiTests by removing redundant namespace references.
- Improved null safety in FakeAdminActionsApi by removing unnecessary null-forgiving operators.
- Streamlined service registration in ServiceCollectionExtensions by removing interface specifications for singleton registrations.
- Enhanced integration test setup by removing specific types in CustomWebApplicationFactory.
- Cleaned up player-related assertions in PlayersTests for better readability.
- Added JSON language annotations in GameServerConfigurationsControllerTests for clarity.
- Updated GameServersControllerTests to ensure proper deserialization of file transport types.
- Introduced .editorconfig for consistent coding standards across the project.
- Refactored constructor assignments in several controllers for improved readability.

Author: frasermolyneux

.editorconfig

@@ -0,0 +1,119 @@
+root = true
+
+[*.{cs,vb}]
+dotnet_analyzer_diagnostic.category-naming.severity = warning
+dotnet_analyzer_diagnostic.category-style.severity = warning
+dotnet_analyzer_diagnostic.category-maintainability.severity = warning
+dotnet_analyzer_diagnostic.category-formatting.severity = warning
+dotnet_analyzer_diagnostic.category-security.severity = warning
+dotnet_analyzer_diagnostic.category-performance.severity = warning
+dotnet_analyzer_diagnostic.category-reliability.severity = warning
+dotnet_analyzer_diagnostic.category-usage.severity = warning
+
+# Lower-noise categories can start at suggestion.
+dotnet_analyzer_diagnostic.category-design.severity = suggestion
+dotnet_analyzer_diagnostic.category-globalization.severity = suggestion
+
+# C# style baseline.
+csharp_using_directive_placement = outside_namespace:warning
+csharp_style_var_for_built_in_types = true:warning
+csharp_style_var_when_type_is_apparent = true:warning
+csharp_style_var_elsewhere = true:warning
+csharp_style_namespace_declarations = file_scoped:warning
+
+# .NET style baseline.
+dotnet_style_qualification_for_field = false:warning
+dotnet_style_qualification_for_property = false:warning
+dotnet_style_qualification_for_method = false:warning
+dotnet_style_qualification_for_event = false:warning
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:warning
+dotnet_style_object_initializer = true:warning
+dotnet_style_collection_initializer = true:warning
+dotnet_style_prefer_auto_properties = true:warning
+dotnet_style_null_propagation = true:warning
+dotnet_style_namespace_match_folder = true:warning
+
+# Public API XML documentation backlog exists; keep strict compiler warnings while not blocking rollout.
+dotnet_diagnostic.CS1570.severity = suggestion
+dotnet_diagnostic.CS1591.severity = suggestion
+
+# Legacy API version namespaces/types intentionally use underscores and versioned names.
+dotnet_diagnostic.CA1707.severity = suggestion
+dotnet_diagnostic.CA1711.severity = suggestion
+dotnet_diagnostic.CA1716.severity = suggestion
+dotnet_diagnostic.CA1720.severity = suggestion
+
+# Defer broad style-only churn in existing code.
+dotnet_diagnostic.IDE0011.severity = suggestion
+dotnet_diagnostic.IDE0022.severity = suggestion
+dotnet_diagnostic.IDE0028.severity = suggestion
+dotnet_diagnostic.IDE0040.severity = suggestion
+dotnet_diagnostic.IDE0048.severity = suggestion
+dotnet_diagnostic.IDE0055.severity = suggestion
+dotnet_diagnostic.IDE0058.severity = suggestion
+dotnet_diagnostic.IDE0072.severity = suggestion
+dotnet_diagnostic.IDE0078.severity = suggestion
+dotnet_diagnostic.IDE0130.severity = suggestion
+dotnet_diagnostic.IDE0161.severity = suggestion
+dotnet_diagnostic.IDE0240.severity = suggestion
+dotnet_diagnostic.IDE0305.severity = suggestion
+dotnet_diagnostic.IDE0306.severity = suggestion
+
+# Defer non-functional analyzer cleanups in existing code.
+dotnet_diagnostic.CA1068.severity = suggestion
+dotnet_diagnostic.CA1304.severity = suggestion
+dotnet_diagnostic.CA1305.severity = suggestion
+dotnet_diagnostic.CA1310.severity = suggestion
+dotnet_diagnostic.CA1311.severity = suggestion
+dotnet_diagnostic.CA1826.severity = suggestion
+dotnet_diagnostic.CA1822.severity = suggestion
+dotnet_diagnostic.CA1848.severity = suggestion
+dotnet_diagnostic.CA1860.severity = suggestion
+dotnet_diagnostic.CA1861.severity = suggestion
+dotnet_diagnostic.CA1862.severity = suggestion
+dotnet_diagnostic.CA1866.severity = suggestion
+dotnet_diagnostic.CA2016.severity = suggestion
+dotnet_diagnostic.CA2201.severity = suggestion
+dotnet_diagnostic.CA1859.severity = suggestion
+dotnet_diagnostic.CA2208.severity = suggestion
+dotnet_diagnostic.CA2249.severity = suggestion
+dotnet_diagnostic.CA1816.severity = suggestion
+
+dotnet_diagnostic.CS1573.severity = suggestion
+
+dotnet_diagnostic.IDE0004.severity = suggestion
+dotnet_diagnostic.IDE0007.severity = suggestion
+dotnet_diagnostic.IDE0018.severity = suggestion
+dotnet_diagnostic.IDE0037.severity = suggestion
+dotnet_diagnostic.IDE0045.severity = suggestion
+dotnet_diagnostic.IDE0046.severity = suggestion
+dotnet_diagnostic.IDE0047.severity = suggestion
+dotnet_diagnostic.IDE0060.severity = suggestion
+dotnet_diagnostic.IDE0063.severity = suggestion
+dotnet_diagnostic.IDE0200.severity = suggestion
+dotnet_diagnostic.IDE0290.severity = suggestion
+dotnet_diagnostic.IDE0300.severity = suggestion
+dotnet_diagnostic.IDE0021.severity = suggestion
+dotnet_diagnostic.IDE0042.severity = suggestion
+dotnet_diagnostic.IDE0301.severity = suggestion
+
+dotnet_diagnostic.xUnit1004.severity = suggestion
+
+# Avoid IDE0005 build coupling to GenerateDocumentationFile during standards rollout.
+dotnet_diagnostic.IDE0005.severity = none
+
+[**/*Tests.cs]
+# Keep descriptive xUnit method names with underscores for readability in test code.
+dotnet_diagnostic.CA1707.severity = none
+
+[*.g.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[*.Designer.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[*.generated.cs]
+dotnet_analyzer_diagnostic.severity = none
+
+[*.AssemblyInfo.cs]
+dotnet_analyzer_diagnostic.severity = none

.github/workflows/build-and-test.yml

@@ -32,7 +32,7 @@ jobs:
       contents: read
     runs-on: ubuntu-latest
     steps:
-      - uses: frasermolyneux/actions/dotnet-ci@dotnet-ci/v1.4
+      - uses: frasermolyneux/actions/dotnet-ci@dotnet-ci/v2
         with:
           dotnet-version: |
             9.0.x

.github/workflows/deploy-dev.yml

@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - id: v1-ci
-        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v1.4
+        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v2
         with:
           dotnet-project: "XtremeIdiots.Portal.Repository.Api.V1"
           dotnet-version: |
@@ -27,7 +27,7 @@ jobs:
           src-folder: "src"
           skip-nuget-artifact-upload: "true"
       - id: v2-ci
-        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v1.4
+        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v2
         with:
           dotnet-project: "XtremeIdiots.Portal.Repository.Api.V2"
           dotnet-version: |

.github/workflows/deploy-prd.yml

@@ -70,7 +70,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - id: v1-ci
-        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v1.4
+        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v2
         with:
           dotnet-project: "XtremeIdiots.Portal.Repository.Api.V1"
           dotnet-version: |
@@ -79,7 +79,7 @@ jobs:
           src-folder: "src"
           skip-nuget-artifact-upload: "true"
       - id: v2-ci
-        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v1.4
+        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v2
         with:
           dotnet-project: "XtremeIdiots.Portal.Repository.Api.V2"
           dotnet-version: |

.github/workflows/pr-verify.yml

@@ -24,7 +24,7 @@ jobs:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
-      - uses: frasermolyneux/actions/dotnet-ci@dotnet-ci/v1.4
+      - uses: frasermolyneux/actions/dotnet-ci@dotnet-ci/v2
         with:
           dotnet-version: |
             9.0.x
@@ -33,7 +33,7 @@ jobs:
           skip-nuget-artifact-upload: "true"
 
       - id: v1-ci
-        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v1.4
+        uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v2
         with:
           dotnet-project: "XtremeIdiots.Portal.Repository.Api.V1"
           dotnet-version: |
@@ -42,7 +42,7 @@ jobs:
           src-folder: "src"
           skip-nuget-artifact-upload: "true"
 
-      - uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v1.4
+      - uses: frasermolyneux/actions/dotnet-web-ci@dotnet-web-ci/v2
         with:
           dotnet-project: "XtremeIdiots.Portal.Repository.Api.V2"
           dotnet-version: |

.github/workflows/release-version-and-tag.yml

@@ -84,7 +84,7 @@ jobs:
       BUILD_VERSION_OVERRIDE: ${{ needs.calculate-version.outputs.nuget_version }}
 
     steps:
-    - uses: frasermolyneux/actions/dotnet-ci@dotnet-ci/v1.4
+    - uses: frasermolyneux/actions/dotnet-ci@dotnet-ci/v2
       with:
         dotnet-version: |
           9.0.x

.vscode/launch.json

@@ -8,7 +8,7 @@
             "name": ".NET Core Launch (web)",
             "type": "coreclr",
             "request": "launch",
-            "preLaunchTask": "build",
+            "preLaunchTask": "dotnet: build",
             // If you have changed target frameworks, make sure to update the program path.
             "program": "${workspaceFolder}/src/XtremeIdiots.Portal.Repository.Api.V1/bin/Debug/net9.0/XtremeIdiots.Portal.Repository.Api.V1.dll",
             "args": [],

.vscode/tasks.json

@@ -2,7 +2,7 @@
     "version": "2.0.0",
     "tasks": [
         {
-            "label": "clean",
+            "label": "dotnet: clean",
             "command": "dotnet",
             "type": "process",
             "args": [
@@ -14,7 +14,7 @@
             "problemMatcher": "$msCompile"
         },
         {
-            "label": "build",
+            "label": "dotnet: build",
             "command": "dotnet",
             "type": "process",
             "args": [
@@ -23,15 +23,15 @@
                 "/property:GenerateFullPaths=true",
                 "/consoleloggerparameters:NoSummary"
             ],
-            "dependsOn": "clean",
+            "dependsOn": "dotnet: clean",
             "group": {
                 "kind": "build",
                 "isDefault": true
             },
             "problemMatcher": "$msCompile"
         },
         {
-            "label": "test",
+            "label": "dotnet: test",
             "command": "dotnet",
             "type": "process",
             "args": [
@@ -49,7 +49,7 @@
             "problemMatcher": "$msCompile"
         },
         {
-            "label": "test-integration",
+            "label": "dotnet: test-integration",
             "command": "dotnet",
             "type": "process",
             "args": [
@@ -66,7 +66,18 @@
             "problemMatcher": "$msCompile"
         },
         {
-            "label": "clean release",
+            "label": "dotnet: format",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "format",
+                "${workspaceFolder}/src/XtremeIdiots.Portal.Repository.sln",
+                "--verify-no-changes"
+            ],
+            "problemMatcher": "$msCompile"
+        },
+        {
+            "label": "dotnet: clean-release",
             "command": "dotnet",
             "type": "process",
             "args": [
@@ -80,7 +91,7 @@
             "problemMatcher": "$msCompile"
         },
         {
-            "label": "publish",
+            "label": "dotnet: publish",
             "command": "dotnet",
             "type": "process",
             "args": [
@@ -91,11 +102,11 @@
                 "/property:GenerateFullPaths=true",
                 "/consoleloggerparameters:NoSummary"
             ],
-            "dependsOn": "clean release",
+            "dependsOn": "dotnet: clean-release",
             "problemMatcher": "$msCompile"
         },
         {
-            "label": "watch",
+            "label": "dotnet: watch",
             "command": "dotnet",
             "type": "process",
             "args": [

Directory.Build.props

@@ -1,6 +1,12 @@
 <Project>
   <PropertyGroup>
     <LangVersion>latest</LangVersion>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <AnalysisLevel>latest-recommended</AnalysisLevel>
+    <CodeAnalysisTreatWarningsAsErrors>true</CodeAnalysisTreatWarningsAsErrors>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
 
     <!-- NuGet package metadata -->
     <Authors>Fraser Molyneux</Authors>