refactor: Replace correlation window variable with constant for clarity

Author: frasermolyneux

src/XtremeIdiots.Portal.Repository.Api.V1/Controllers/V1/ServerAnalyticsController.cs

@@ -91,7 +91,7 @@ async Task<ApiResult<ServerOverviewDto>> IServerAnalyticsApi.GetOverview(Guid ga
             .AsNoTracking()
             .CountAsync(r => r.GameServerId == gameServerId && r.Timestamp >= fromUtc && r.Timestamp < toUtc, cancellationToken).ConfigureAwait(false);
 
-        var correlationWindow = TimeSpan.FromHours(6);
+        const double correlationWindowHours = 6;
         var adminActionsCount = await context.AdminActions
             .AsNoTracking()
             .CountAsync(a =>
@@ -100,8 +100,8 @@ async Task<ApiResult<ServerOverviewDto>> IServerAnalyticsApi.GetOverview(Guid ga
                 && context.RecentPlayers.Any(rp =>
                     rp.PlayerId == a.PlayerId
                     && rp.GameServerId == gameServerId
-                    && rp.Timestamp >= a.Created - correlationWindow
-                    && rp.Timestamp <= a.Created + correlationWindow),
+                    && rp.Timestamp >= a.Created.AddHours(-correlationWindowHours)
+                    && rp.Timestamp <= a.Created.AddHours(correlationWindowHours)),
                 cancellationToken).ConfigureAwait(false);
 
         var dto = new ServerOverviewDto