Refine broadcasts defaults and preview color behavior

Co-authored-by: frasermolyneux <34033625+frasermolyneux@users.noreply.github.com>

Author: Copilot

src/XtremeIdiots.Portal.Web/Controllers/GameServersController.cs

@@ -628,7 +628,7 @@ private void PopulateConfigFromNamespace(GameServerEditViewModel editModel, Conf
                     break;
                 case "broadcasts":
                     editModel.BroadcastsEnabled = GetBoolProperty(root, "enabled", false);
-                    editModel.BroadcastsIntervalSeconds = GetNullableIntProperty(root, "intervalSeconds") ?? 500;
+                    editModel.BroadcastsIntervalSeconds = GetNullableIntProperty(root, "intervalSeconds") ?? GameServerEditViewModel.DefaultBroadcastIntervalSeconds;
                     editModel.BroadcastMessages = GetBroadcastMessages(root);
                     break;
                 default:
@@ -923,9 +923,9 @@ await UpsertConfigSafeAsync(gameServerId, "events",
         // Save Broadcasts config (only when Agent is enabled)
         if (model.GameServer.AgentEnabled)
         {
-            var broadcastsIntervalSeconds = model.BroadcastsIntervalSeconds.GetValueOrDefault(500);
+            var broadcastsIntervalSeconds = model.BroadcastsIntervalSeconds.GetValueOrDefault(GameServerEditViewModel.DefaultBroadcastIntervalSeconds);
             if (broadcastsIntervalSeconds <= 0)
-                broadcastsIntervalSeconds = 500;
+                broadcastsIntervalSeconds = GameServerEditViewModel.DefaultBroadcastIntervalSeconds;
 
             var broadcastsConfig = new
             {

src/XtremeIdiots.Portal.Web/ViewModels/GameServerEditViewModel.cs

@@ -8,6 +8,9 @@ namespace XtremeIdiots.Portal.Web.ViewModels;
 /// </summary>
 public class GameServerEditViewModel : IValidatableObject
 {
+    public const int DefaultBroadcastIntervalSeconds = 500;
+    public const int MaxBroadcastMessageLength = 120;
+
     /// <summary>
     /// Core game server data
     /// </summary>
@@ -94,7 +97,7 @@ public class GameServerEditViewModel : IValidatableObject
 
     [DisplayName("Interval (seconds)")]
     [Range(1, 86400, ErrorMessage = "Broadcast interval must be between 1 and 86400 seconds.")]
-    public int? BroadcastsIntervalSeconds { get; set; } = 500;
+    public int? BroadcastsIntervalSeconds { get; set; } = DefaultBroadcastIntervalSeconds;
 
     public List<BroadcastMessageViewModel> BroadcastMessages { get; set; } = [];
 
@@ -117,8 +120,8 @@ public IEnumerable<ValidationResult> Validate(ValidationContext validationContex
     {
         for (var i = 0; i < BroadcastMessages.Count; i++)
         {
-            if (BroadcastMessages[i].Message?.Length > 120)
-                yield return new ValidationResult("Broadcast message cannot exceed 120 characters.", [$"BroadcastMessages[{i}].Message"]);
+            if (BroadcastMessages[i].Message?.Length > MaxBroadcastMessageLength)
+                yield return new ValidationResult($"Broadcast message cannot exceed {MaxBroadcastMessageLength} characters.", [$"BroadcastMessages[{i}].Message"]);
         }
     }
 }

src/XtremeIdiots.Portal.Web/Views/GameServers/ConfigurationSections/_BroadcastsConfiguration.cshtml

@@ -19,7 +19,7 @@
             <label asp-for="BroadcastsIntervalSeconds" class="form-label"></label>
             <input asp-for="BroadcastsIntervalSeconds" class="form-control" type="number" min="1" max="86400" />
             <span asp-validation-for="BroadcastsIntervalSeconds" class="text-danger"></span>
-            <small class="form-text text-muted">Interval between broadcasts in seconds. Defaults to 500 when unset.</small>
+            <small class="form-text text-muted">Interval between broadcasts in seconds. Default: @GameServerEditViewModel.DefaultBroadcastIntervalSeconds seconds.</small>
         </div>
     </div>
 </div>
@@ -65,8 +65,8 @@
                             </button>
                         </div>
                     </div>
-                    <input class="form-control" data-field="message" asp-for="BroadcastMessages[i].Message" maxlength="120" />
-                    <small class="form-text text-muted"><span data-field="char-count">0</span>/120 characters</small>
+                    <input class="form-control" data-field="message" asp-for="BroadcastMessages[i].Message" maxlength="@GameServerEditViewModel.MaxBroadcastMessageLength" />
+                    <small class="form-text text-muted"><span data-field="char-count">0</span>/@GameServerEditViewModel.MaxBroadcastMessageLength characters</small>
                     <div class="small text-muted mt-1" data-field="preview">(preview)</div>
                     <span class="text-danger" data-field="validation" asp-validation-for="BroadcastMessages[i].Message"></span>
                 </div>
@@ -95,8 +95,8 @@
                 </button>
             </div>
         </div>
-        <input class="form-control" data-field="message" maxlength="120" />
-        <small class="form-text text-muted"><span data-field="char-count">0</span>/120 characters</small>
+        <input class="form-control" data-field="message" maxlength="@GameServerEditViewModel.MaxBroadcastMessageLength" />
+        <small class="form-text text-muted"><span data-field="char-count">0</span>/@GameServerEditViewModel.MaxBroadcastMessageLength characters</small>
         <div class="small text-muted mt-1" data-field="preview">(preview)</div>
         <span class="text-danger" data-field="validation"></span>
     </div>

src/XtremeIdiots.Portal.Web/Views/GameServers/Edit.cshtml

@@ -297,7 +297,7 @@
                 '0': '#ffffff'
             };
 
-            var currentColor = colors['7'];
+            var currentColor = colors['0'];
             var lastIndex = 0;
             var regex = /\^([0-9])/g;
             var match;