feat: Add filtering options for Ban File Monitors dashboard and update UI messages

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Controllers/BanFileMonitorsController.cs

@@ -40,7 +40,9 @@ public class BanFileMonitorsController(
     /// each server is protected and in sync with the central ban file.
     /// </summary>
     [HttpGet]
-    public async Task<IActionResult> Index(CancellationToken cancellationToken = default)
+    public async Task<IActionResult> Index(
+        [FromQuery] bool showAll = false,
+        CancellationToken cancellationToken = default)
     {
         return await ExecuteWithErrorHandlingAsync(async () =>
         {
@@ -64,7 +66,23 @@ public async Task<IActionResult> Index(CancellationToken cancellationToken = def
                 return RedirectToAction("Display", "Errors", new { id = 500 });
             }
 
-            var monitors = monitorsResponse.Result.Data.Items.ToList();
+            var allMonitors = monitorsResponse.Result.Data.Items.ToList();
+
+            // Active monitors are the ones the agent will actually run a check loop for.
+            // Anything else (sync disabled or agent disabled) clutters the dashboard with
+            // stale data and is hidden by default; admins can opt in via ?showAll=true to
+            // diagnose misconfigurations.
+            static bool IsActive(XtremeIdiots.Portal.Repository.Abstractions.Models.V1.BanFileMonitors.BanFileMonitorDto m)
+            {
+                return m.GameServer is not null
+                    && m.GameServer.BanFileSyncEnabled
+                    && m.GameServer.AgentEnabled;
+            }
+
+            var hiddenCount = showAll ? 0 : allMonitors.Count(m => !IsActive(m));
+            var monitors = showAll
+                ? (IReadOnlyList<XtremeIdiots.Portal.Repository.Abstractions.Models.V1.BanFileMonitors.BanFileMonitorDto>)allMonitors
+                : allMonitors.Where(IsActive).ToList();
 
             var liveStatusResponse = await liveStatusTask.ConfigureAwait(false);
             var liveStatusLookup = liveStatusResponse.IsSuccess && liveStatusResponse.Result?.Data?.Items is not null
@@ -81,7 +99,9 @@ public async Task<IActionResult> Index(CancellationToken cancellationToken = def
                 ? activeBanCountsResponse.Result.Data.Items.ToDictionary(c => c.GameType)
                 : [];
 
-            // Build per-game-type roll-up cards for game types the user can see.
+            // Per-game-type cards reflect the full ban-counts view (DB has the same active
+            // bans regardless of which servers happen to be enabled), but the visible
+            // game-type set follows the currently-displayed monitors.
             var visibleGameTypes = monitors
                 .Where(m => m.GameServer is not null)
                 .Select(m => m.GameServer.GameType)
@@ -105,7 +125,9 @@ public async Task<IActionResult> Index(CancellationToken cancellationToken = def
                 Monitors = monitors,
                 LiveStatusLookup = liveStatusLookup,
                 ServerConfigs = serverConfigs,
-                GameTypeCards = gameTypeCards
+                GameTypeCards = gameTypeCards,
+                ShowingAll = showAll,
+                HiddenInactiveCount = hiddenCount
             };
 
             return View(viewModel);

src/XtremeIdiots.Portal.Web/ViewModels/BanFileMonitorsDashboardViewModel.cs

@@ -24,6 +24,12 @@ public sealed class BanFileMonitorsDashboardViewModel
     public required IReadOnlyDictionary<Guid, Dictionary<string, System.Text.Json.JsonElement>> ServerConfigs { get; init; }
 
     public required IReadOnlyList<BanFileMonitorGameTypeCard> GameTypeCards { get; init; }
+
+    /// <summary>True when the dashboard is showing every monitor, false when filtered to active.</summary>
+    public required bool ShowingAll { get; init; }
+
+    /// <summary>Count of monitors hidden by the active-only filter (zero when ShowingAll is true).</summary>
+    public required int HiddenInactiveCount { get; init; }
 }
 
 /// <summary>

src/XtremeIdiots.Portal.Web/Views/BanFileMonitors/Index.cshtml

@@ -103,14 +103,32 @@
 
 <div class="wrapper wrapper-content animated fadeInRight">
 
-    <div class="alert alert-primary" role="alert">
-        <i class="fa-solid fa-fw fa-circle-info" aria-hidden="true"></i>
-        Ban file monitors are now <strong>read-only status snapshots</strong> written by the server agent.
-        To enable / disable monitoring for a server, toggle <strong>Agent Enabled</strong> + <strong>Ban File Sync</strong> on
-        <a asp-controller="GameServers" asp-action="Index">the game server's edit page</a>.
-        Ban file sync is a sub-feature of the agent and requires Agent Enabled. The FTP path is resolved
-        automatically from the server's <strong>Ban File Root Path</strong> plus per-game-type rules and
-        the currently-running mod.
+    <div class="alert alert-primary d-flex align-items-start" role="alert">
+        <i class="fa-solid fa-fw fa-circle-info me-2 mt-1" aria-hidden="true"></i>
+        <div class="flex-grow-1">
+            Ban file monitors are <strong>read-only status snapshots</strong> written by the server agent.
+            To enable / disable monitoring for a server, toggle <strong>Agent Enabled</strong> + <strong>Ban File Sync</strong>
+            on <a asp-controller="GameServers" asp-action="Index">the game server's edit page</a>.
+            Ban file sync is a sub-feature of the agent and requires Agent Enabled. The FTP path is resolved
+            automatically from the server's <strong>Ban File Root Path</strong> plus per-game-type rules and
+            the currently-running mod.
+
+            @if (Model.ShowingAll)
+            {
+                <div class="mt-2">
+                    <i class="fa-solid fa-fw fa-eye" aria-hidden="true"></i> Showing <strong>all monitors</strong>, including disabled and misconfigured.
+                    <a asp-action="Index">Show active only</a>
+                </div>
+            }
+            else if (Model.HiddenInactiveCount > 0)
+            {
+                <div class="mt-2">
+                    <i class="fa-solid fa-fw fa-eye-slash" aria-hidden="true"></i>
+                    @Model.HiddenInactiveCount monitor(s) hidden because Ban File Sync or Agent is disabled.
+                    <a asp-action="Index" asp-route-showAll="true">Show all</a>
+                </div>
+            }
+        </div>
     </div>
 
     @if (Model.GameTypeCards.Count > 0)