feat: Add cancel operation functionality for map rotations with user confirmation

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Controllers/MapRotationsController.cs

@@ -723,4 +723,72 @@ public async Task<IActionResult> GetSyncProgress(string instanceId, Cancellation
             _ => Json(new { status = "error" })
         };
     }
+
+    [HttpPost]
+    [ValidateAntiForgeryToken]
+    public async Task<IActionResult> CancelOperation(Guid operationId, Guid assignmentId, CancellationToken cancellationToken = default)
+    {
+        return await ExecuteWithErrorHandlingAsync(async () =>
+        {
+            var assignmentResponse = await repositoryApiClient.MapRotations.V1.GetServerAssignment(assignmentId, cancellationToken).ConfigureAwait(false);
+
+            if (assignmentResponse.IsNotFound || assignmentResponse.Result?.Data is null)
+                return NotFound();
+
+            var assignment = assignmentResponse.Result.Data;
+
+            var rotationResponse = await repositoryApiClient.MapRotations.V1.GetMapRotation(assignment.MapRotationId, cancellationToken).ConfigureAwait(false);
+
+            if (rotationResponse.IsNotFound || rotationResponse.Result?.Data is null)
+                return NotFound();
+
+            var rotation = rotationResponse.Result.Data;
+
+            var authResult = await CheckAuthorizationAsync(
+                authorizationService,
+                rotation.GameType,
+                AuthPolicies.ManageMapRotations,
+                nameof(CancelOperation),
+                "MapRotation").ConfigureAwait(false);
+
+            if (authResult != null)
+                return authResult;
+
+            var updateResult = await repositoryApiClient.MapRotations.V1.UpdateAssignmentOperation(
+                operationId, AssignmentOperationStatus.Cancelled, "Manually cancelled by user").ConfigureAwait(false);
+
+            if (updateResult.IsSuccess)
+            {
+                // Also reset the assignment state so the user can retry
+                var deploymentReset = assignment.DeploymentState is DeploymentState.Syncing or DeploymentState.Removing
+                    ? DeploymentState.Failed
+                    : (DeploymentState?)null;
+
+                var activationReset = assignment.ActivationState is ActivationState.Activating or ActivationState.Deactivating
+                    ? ActivationState.Inactive
+                    : (ActivationState?)null;
+
+                if (deploymentReset.HasValue || activationReset.HasValue)
+                {
+                    var resetDto = new UpdateMapRotationServerAssignmentDto(assignmentId)
+                    {
+                        DeploymentState = deploymentReset,
+                        ActivationState = activationReset,
+                        LastError = "Operation cancelled by user",
+                        LastErrorAt = DateTime.UtcNow
+                    };
+
+                    await repositoryApiClient.MapRotations.V1.UpdateServerAssignment(resetDto, cancellationToken).ConfigureAwait(false);
+                }
+
+                this.AddAlertSuccess("Operation cancelled successfully.");
+            }
+            else
+            {
+                this.AddAlertDanger("Failed to cancel operation. Please try again.");
+            }
+
+            return RedirectToAction(nameof(AssignmentStatus), new { id = assignmentId });
+        }, nameof(CancelOperation)).ConfigureAwait(false);
+    }
 }

src/XtremeIdiots.Portal.Web/Views/MapRotations/AssignmentStatus.cshtml

@@ -165,6 +165,7 @@
                                             <th>Duration</th>
                                             <th>Instance</th>
                                             <th>Error</th>
+                                            <th></th>
                                         </tr>
                                     </thead>
                                     <tbody>
@@ -176,9 +177,10 @@
                                                 <td colspan="3"><span class="text-muted">Operation is being initialized...</span></td>
                                                 <td><code class="small" title="@pendingInstanceId">@(pendingInstanceId.Length > 20 ? pendingInstanceId[..20] + "…" : pendingInstanceId)</code></td>
                                                 <td></td>
+                                                <td></td>
                                             </tr>
                                             <tr class="progress-detail-row">
-                                                <td colspan="7" class="p-0 border-0">
+                                                <td colspan="8" class="p-0 border-0">
                                                     <div class="px-3 py-2 bg-light">
                                                         <div class="d-flex justify-content-between mb-1">
                                                             <span class="progress-label">Waiting for orchestration to start...</span>
@@ -254,11 +256,24 @@
                                                         <span class="text-danger" title="@op.Error">@(op.Error.Length > 60 ? op.Error[..60] + "..." : op.Error)</span>
                                                     }
                                                 </td>
+                                                <td>
+                                                    @if (isInProgress)
+                                                    {
+                                                        <form policy="@AuthPolicies.ManageMapRotations" asp-action="CancelOperation" method="post" class="d-inline">
+                                                            @Html.AntiForgeryToken()
+                                                            <input type="hidden" name="operationId" value="@op.MapRotationAssignmentOperationId" />
+                                                            <input type="hidden" name="assignmentId" value="@Model.Assignment.MapRotationServerAssignmentId" />
+                                                            <button type="submit" class="btn btn-outline-danger btn-sm" onclick="return confirm('Cancel this operation? The assignment state will be reset so you can retry.')">
+                                                                <i class="fa-solid fa-ban"></i> Cancel
+                                                            </button>
+                                                        </form>
+                                                    }
+                                                </td>
                                             </tr>
                                             @if (isInProgress)
                                             {
                                                 <tr class="progress-detail-row">
-                                                    <td colspan="7" class="p-0 border-0">
+                                                    <td colspan="8" class="p-0 border-0">
                                                         <div class="px-3 py-2 bg-light">
                                                             @if (string.IsNullOrEmpty(op.DurableFunctionInstanceId))
                                                             {