feat: Normalize funny message enabled values in GlobalSettingsController and update form submission logic in Index view

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Controllers/GlobalSettingsController.cs

@@ -66,6 +66,8 @@ public async Task<IActionResult> Index(GlobalSettingsViewModel model, Cancellati
     {
         return await ExecuteWithErrorHandlingAsync(async () =>
         {
+            NormalizeFunnyMessageEnabledValuesFromForm(model);
+
             var modelStateResult = CheckModelState(model);
             if (modelStateResult is not null)
                 return modelStateResult;
@@ -268,4 +270,22 @@ private async Task UpsertConfigSafeAsync(
             errors.Add(ns);
         }
     }
+
+    private void NormalizeFunnyMessageEnabledValuesFromForm(GlobalSettingsViewModel model)
+    {
+        if (model.FunnyMessages is null || model.FunnyMessages.Count == 0)
+            return;
+
+        for (var i = 0; i < model.FunnyMessages.Count; i++)
+        {
+            if (!Request.Form.TryGetValue($"FunnyMessages[{i}].Enabled", out var values))
+            {
+                model.FunnyMessages[i].Enabled = false;
+                continue;
+            }
+
+            model.FunnyMessages[i].Enabled = values.Any(value =>
+                bool.TryParse(value, out var parsed) && parsed);
+        }
+    }
 }

src/XtremeIdiots.Portal.Web/Views/GlobalSettings/Index.cshtml

@@ -476,7 +476,7 @@
                                                                 reindexGlobalFunnyRows(container);
                                                                 updateGlobalFunnyEmptyState(container);
 
-                                                                var form = document.querySelector('form[action*="Index"]');
+                                                                var form = container.closest('form') || document.querySelector('form[method="post"]');
                                                                 if (form) {
                                                                     form.addEventListener('submit', function () {
                                                                         reindexGlobalFunnyRows(container);