Fix "View all notifications" link navigating to preferences instead of notifications list (#165)

* Initial plan

* Fix 'View all notifications' link to point to AllNotifications action

Co-authored-by: frasermolyneux <34033625+frasermolyneux@users.noreply.github.com>

* Fix pre-existing IDE0390 build error in BannersController

Co-authored-by: frasermolyneux <34033625+frasermolyneux@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: frasermolyneux <34033625+frasermolyneux@users.noreply.github.com>

Author: Copilot

src/XtremeIdiots.Portal.Web/Controllers/BannersController.cs

@@ -29,7 +29,7 @@ public class BannersController(
     public async Task<IActionResult> GameServersList(CancellationToken cancellationToken = default)
     {
         return await ExecuteWithErrorHandlingAsync(
-            async () => View(),
+            () => Task.FromResult<IActionResult>(View()),
             "Display game servers list view for banner management").ConfigureAwait(false);
     }
 }

src/XtremeIdiots.Portal.Web/Views/Shared/_TopNavbar.cshtml

@@ -41,7 +41,7 @@
                             </div>
                         </div>
                         <div class="border-top px-3 py-2 text-center">
-                            <a href="/Profile/Notifications" class="text-decoration-none small">View all notifications</a>
+                            <a asp-controller="Profile" asp-action="AllNotifications" class="text-decoration-none small">View all notifications</a>
                         </div>
                     </div>
                 </li>