fix: change service lifetime from Singleton to Scoped for forum integration services

Author: frasermolyneux

src/XtremeIdiots.Portal.Integrations.Forums/Extensions/ServiceCollectionExtensions.cs

@@ -13,7 +13,7 @@ public static class ServiceCollectionExtensions
     /// <param name="serviceCollection">The service collection to configure</param>
     public static void AddAdminActionTopics(this IServiceCollection serviceCollection)
     {
-        serviceCollection.AddSingleton<IAdminActionTopics, AdminActionTopics>();
-        serviceCollection.AddSingleton<IDemoManager, DemoManager>();
+        serviceCollection.AddScoped<IAdminActionTopics, AdminActionTopics>();
+        serviceCollection.AddScoped<IDemoManager, DemoManager>();
     }
 }

terraform/providers.tf

@@ -18,7 +18,6 @@ terraform {
 
 provider "azurerm" {
   subscription_id                 = var.subscription_id
-  resource_provider_registrations = "none"
 
   features {
     resource_group {
@@ -36,7 +35,6 @@ provider "azuread" {
 provider "azurerm" {
   alias                           = "dns"
   subscription_id                 = var.dns_subscription_id
-  resource_provider_registrations = "none"
 
   features {}