test: Enhance ProfileControllerTests with activation code failure handling and linked players mapping

Author: frasermolyneux

src/XtremeIdiots.Portal.Web.Tests/Controllers/ProfileControllerTests.cs

@@ -134,6 +134,92 @@ public async Task ActivateConnectedPlayerCode_WhenProfileFound_CallsActivationEn
             .Verify(x => x.ConnectedPlayers.V1.ActivateConnectedPlayerActivationCode(
                 It.Is<ActivateConnectedPlayerActivationCodeDto>(dto => dto.UserProfileId == userProfileId),
                 It.IsAny<CancellationToken>()), Times.Once);
+
+        Assert.Contains("Activation code generated", sut.TempData["Alerts"]?.ToString() ?? string.Empty, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public async Task ActivateConnectedPlayerCode_WhenActivationFails_AddsFailureAlert()
+    {
+        // Arrange
+        var userProfileId = Guid.NewGuid();
+        var userProfile = CreateUserProfileDto(userProfileId);
+
+        mockRepositoryApiClient
+            .Setup(x => x.UserProfiles.V1.GetUserProfileByXtremeIdiotsId(It.IsAny<string>(), It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new ApiResult<UserProfileDto>(HttpStatusCode.OK, new ApiResponse<UserProfileDto>(userProfile)));
+
+        mockRepositoryApiClient
+            .Setup(x => x.ConnectedPlayers.V1.ActivateConnectedPlayerActivationCode(It.IsAny<ActivateConnectedPlayerActivationCodeDto>(), It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new ApiResult<ConnectedPlayerActivationCodeDto>(HttpStatusCode.BadRequest));
+
+        var user = new ClaimsPrincipal(
+            new ClaimsIdentity([
+                new Claim(UserProfileClaimType.XtremeIdiotsId, "123456")
+            ], "TestAuth"));
+
+        var sut = CreateSut(user);
+
+        // Act
+        var result = await sut.ActivateConnectedPlayerCode();
+
+        // Assert
+        var redirectResult = Assert.IsType<RedirectToActionResult>(result);
+        Assert.Equal(nameof(ProfileController.Manage), redirectResult.ActionName);
+        Assert.Contains("Failed to generate activation code", sut.TempData["Alerts"]?.ToString() ?? string.Empty, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public async Task Manage_WhenProfileFound_MapsActivationAndLinkedPlayersWithCappedFlag()
+    {
+        // Arrange
+        var userProfileId = Guid.NewGuid();
+        var userProfile = CreateUserProfileDto(userProfileId);
+
+        mockRepositoryApiClient
+            .Setup(x => x.UserProfiles.V1.GetUserProfileByXtremeIdiotsId(It.IsAny<string>(), It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new ApiResult<UserProfileDto>(HttpStatusCode.OK, new ApiResponse<UserProfileDto>(userProfile)));
+
+        var activationCode = CreateActivationCodeDto(userProfileId, "QW12ER");
+        mockRepositoryApiClient
+            .Setup(x => x.ConnectedPlayers.V1.GetActiveConnectedPlayerActivationCode(userProfileId, It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new ApiResult<ConnectedPlayerActivationCodeDto>(HttpStatusCode.OK, new ApiResponse<ConnectedPlayerActivationCodeDto>(activationCode)));
+
+        var linkedPlayers = new CollectionModel<ConnectedPlayerDto>([
+            CreateConnectedPlayerDto(userProfileId, "Alpha", true, null),
+            CreateConnectedPlayerDto(userProfileId, "Bravo", false, DateTime.UtcNow.AddDays(-1))
+        ]);
+        var linkedPlayersResponse = new ApiResponse<CollectionModel<ConnectedPlayerDto>>(linkedPlayers)
+        {
+            Pagination = new ApiPagination(totalCount: 150, filteredCount: 150, skip: 0, top: 100)
+        };
+
+        mockRepositoryApiClient
+            .Setup(x => x.ConnectedPlayers.V1.GetConnectedPlayersByUserProfile(userProfileId, 0, 100, It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new ApiResult<CollectionModel<ConnectedPlayerDto>>(HttpStatusCode.OK, linkedPlayersResponse));
+
+        var user = new ClaimsPrincipal(
+            new ClaimsIdentity([
+                new Claim(UserProfileClaimType.XtremeIdiotsId, "123456")
+            ], "TestAuth"));
+
+        var sut = CreateSut(user);
+
+        // Act
+        var result = await sut.Manage();
+
+        // Assert
+        var viewResult = Assert.IsType<ViewResult>(result);
+        var model = Assert.IsType<ProfileManageViewModel>(viewResult.Model);
+
+        Assert.Equal(userProfileId, model.UserProfileId);
+        Assert.NotNull(model.ActiveActivationCode);
+        Assert.Equal("QW12ER", model.ActiveActivationCode!.Code);
+        Assert.Equal(2, model.LinkedPlayers.Count);
+        Assert.Equal(150, model.TotalLinkedPlayers);
+        Assert.True(model.IsLinkedPlayersCapped);
+        Assert.Contains(model.LinkedPlayers, x => x.Username == "Alpha" && x.IsActive);
+        Assert.Contains(model.LinkedPlayers, x => x.Username == "Bravo" && !x.IsActive);
     }
 
     private static UserProfileDto CreateUserProfileDto(Guid userProfileId)
@@ -165,4 +251,24 @@ private static ConnectedPlayerActivationCodeDto CreateActivationCodeDto(Guid use
 
         return JsonConvert.DeserializeObject<ConnectedPlayerActivationCodeDto>(json)!;
     }
+
+    private static ConnectedPlayerDto CreateConnectedPlayerDto(Guid userProfileId, string username, bool isActive, DateTime? unlinkedAtUtc)
+    {
+        var json = JsonConvert.SerializeObject(new
+        {
+            ConnectedPlayerProfileId = Guid.NewGuid(),
+            PlayerId = Guid.NewGuid(),
+            UserProfileId = userProfileId,
+            GameType = GameType.CallOfDuty4,
+            Username = username,
+            LinkMethod = ConnectedPlayerLinkMethod.ActivationCode,
+            LinkedAtUtc = DateTime.UtcNow.AddDays(-2),
+            LinkedByUserProfileId = userProfileId,
+            UnlinkedAtUtc = unlinkedAtUtc,
+            UnlinkedByUserProfileId = unlinkedAtUtc.HasValue ? (Guid?)userProfileId : null,
+            IsActive = isActive
+        });
+
+        return JsonConvert.DeserializeObject<ConnectedPlayerDto>(json)!;
+    }
 }