Refactor IdentityHostingStartup: encapsulate configuration retrieval in GetConfigurationValue method for improved maintainability and clarity.

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Areas/Identity/IdentityHostingStartup.cs

@@ -19,6 +19,8 @@ public class IdentityHostingStartup : IHostingStartup
 {
     private const string AuthClientIdKey = "XtremeIdiots:Auth:ClientId";
     private const string AuthClientSecretKey = "XtremeIdiots:Auth:ClientSecret";
+    private const string AppConfigNamespacePrefix = "XtremeIdiots.Portal.Web:";
+    private const string SqlConnectionStringKey = "sql_connection_string";
 
     private const int SecurityStampValidationIntervalMinutes = 15;
     private const int CookieExpirationDays = 7;
@@ -45,12 +47,12 @@ private static void ValidateConfiguration(IConfiguration configuration)
         {
             AuthClientIdKey,
             AuthClientSecretKey,
-            "sql_connection_string"
+            SqlConnectionStringKey
         };
 
         foreach (var key in requiredKeys)
         {
-            if (string.IsNullOrEmpty(configuration[key]))
+            if (string.IsNullOrEmpty(GetConfigurationValue(configuration, key)))
             {
                 throw new InvalidOperationException($"Required configuration key '{key}' is missing or empty");
             }
@@ -60,7 +62,7 @@ private static void ValidateConfiguration(IConfiguration configuration)
     private static void ConfigureDatabase(IServiceCollection services, IConfiguration configuration)
     {
         services.AddDbContext<IdentityDataContext>(options =>
-            options.UseSqlServer(configuration["sql_connection_string"]));
+            options.UseSqlServer(GetConfigurationValue(configuration, SqlConnectionStringKey)));
     }
 
     private static void ConfigureIdentity(IServiceCollection services)
@@ -106,8 +108,8 @@ private static void ConfigureAuthentication(IServiceCollection services, IConfig
         })
         .AddOAuth(OAuthSchemeName, options =>
         {
-            options.ClientId = configuration[AuthClientIdKey] ?? throw new InvalidOperationException("OAuth client ID is required");
-            options.ClientSecret = configuration[AuthClientSecretKey] ?? throw new InvalidOperationException("OAuth client secret is required");
+            options.ClientId = GetConfigurationValue(configuration, AuthClientIdKey) ?? throw new InvalidOperationException("OAuth client ID is required");
+            options.ClientSecret = GetConfigurationValue(configuration, AuthClientSecretKey) ?? throw new InvalidOperationException("OAuth client secret is required");
 
             options.CallbackPath = new PathString("/signin-xtremeidiots");
 
@@ -158,4 +160,9 @@ private static void ConfigureDataProtection(IServiceCollection services)
             .SetApplicationName(ApplicationName)
             .PersistKeysToDbContext<IdentityDataContext>();
     }
+
+    private static string? GetConfigurationValue(IConfiguration configuration, string key)
+    {
+        return configuration[key] ?? configuration[$"{AppConfigNamespacePrefix}{key}"];
+    }
 }