feat: Implement GameTypeExtensions for display name conversion and update PermissionsReport to use new method

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Extensions/GameTypeExtensions.cs

@@ -0,0 +1,21 @@
+using System.ComponentModel.DataAnnotations;
+using XtremeIdiots.Portal.Repository.Abstractions.Constants.V1;
+
+namespace XtremeIdiots.Portal.Web.Extensions;
+
+public static class GameTypeExtensions
+{
+    public static string ToDisplayName(this GameType gameType)
+    {
+        var memberInfo = typeof(GameType).GetMember(gameType.ToString());
+        if (memberInfo.Length > 0)
+        {
+            var displayAttr = memberInfo[0]
+                .GetCustomAttributes(typeof(DisplayAttribute), false)
+                .FirstOrDefault() as DisplayAttribute;
+            if (displayAttr?.Name is not null)
+                return displayAttr.Name;
+        }
+        return gameType.ToString();
+    }
+}

src/XtremeIdiots.Portal.Web/Services/NotificationDispatcher.cs

@@ -2,6 +2,7 @@
 using XtremeIdiots.Portal.Repository.Abstractions.Constants.V1;
 using XtremeIdiots.Portal.Repository.Abstractions.Models.V1.Notifications;
 using XtremeIdiots.Portal.Repository.Api.Client.V1;
+using XtremeIdiots.Portal.Web.Extensions;
 
 namespace XtremeIdiots.Portal.Web.Services;
 
@@ -176,19 +177,4 @@ private static string BuildMetadata(AdminActionNotificationContext context)
     }
 }
 
-internal static class GameTypeExtensions
-{
-    public static string ToDisplayName(this GameType gameType)
-    {
-        var memberInfo = typeof(GameType).GetMember(gameType.ToString());
-        if (memberInfo.Length > 0)
-        {
-            var displayAttr = memberInfo[0]
-                .GetCustomAttributes(typeof(System.ComponentModel.DataAnnotations.DisplayAttribute), false)
-                .FirstOrDefault() as System.ComponentModel.DataAnnotations.DisplayAttribute;
-            if (displayAttr?.Name is not null)
-                return displayAttr.Name;
-        }
-        return gameType.ToString();
-    }
-}
+

src/XtremeIdiots.Portal.Web/Views/User/PermissionsReport.cshtml

@@ -10,7 +10,7 @@
                 <option value="">All Games</option>
                 @foreach (var gt in new[] { GameType.CallOfDuty2, GameType.CallOfDuty4, GameType.CallOfDuty5, GameType.Insurgency })
                 {
-                    <option value="@gt">@gt.DisplayName()</option>
+                    <option value="@gt">@gt.ToDisplayName()</option>
                 }
             </select>
         </div>