Improve error handling for member retrieval in forums API calls and add cancellation token support

Author: frasermolyneux

src/XtremeIdiots.Portal.Integrations.Forums/AdminActionTopics.cs

@@ -45,7 +45,7 @@ public async Task<int> CreateTopicForAdminAction(AdminActionType type, GameType
                 _ => 28
             };
 
-            var postTopicResult = await forumsClient.Forums.PostTopic(forumId, userId, $"{username} - {type}", PostContent(type, playerId, username, created, text), type.ToString()).ConfigureAwait(false);
+            var postTopicResult = await forumsClient.Forums.PostTopic(forumId, userId, $"{username} - {type}", PostContent(type, playerId, username, created, text), type.ToString(), cancellationToken).ConfigureAwait(false);
 
             if (postTopicResult?.Result?.Data is null)
             {
@@ -88,7 +88,7 @@ public async Task UpdateTopicForAdminAction(int topicId, AdminActionType type, G
         if (adminId is not null)
             userId = Convert.ToInt32(adminId);
 
-        await forumsClient.Forums.UpdateTopic(topicId, userId, PostContent(type, playerId, username, created, text)).ConfigureAwait(false);
+        await forumsClient.Forums.UpdateTopic(topicId, userId, PostContent(type, playerId, username, created, text), cancellationToken).ConfigureAwait(false);
     }
 
     private static string PostContent(AdminActionType type, Guid playerId, string username, DateTime created, string text)

src/XtremeIdiots.Portal.Web/Auth/XtremeIdiots/XtremeIdiotsAuth.cs

@@ -75,7 +75,13 @@ private async Task UpdateExistingUser(ExternalLoginInfo info, CancellationToken
             cancellationToken.ThrowIfCancellationRequested();
 
             var memberResult = await forumsClient.Core.GetMember(id, cancellationToken).ConfigureAwait(false);
-            var member = memberResult?.Result?.Data ?? throw new InvalidOperationException($"Member not found with ID: {id}");
+
+            if (memberResult is null || !memberResult.IsSuccess)
+            {
+                throw new InvalidOperationException($"Forums API call failed for member ID: {id} with status: {memberResult?.StatusCode.ToString() ?? "null response"}");
+            }
+
+            var member = memberResult.Result?.Data ?? throw new InvalidOperationException($"Member not found with ID: {id}");
             var user = await userManager.FindByLoginAsync(info.LoginProvider, info.ProviderKey).ConfigureAwait(false) ?? throw new InvalidOperationException($"User not found for login provider: {info.LoginProvider}, key: {info.ProviderKey}");
             cancellationToken.ThrowIfCancellationRequested();
 
@@ -128,7 +134,13 @@ private async Task RegisterNewUser(ExternalLoginInfo info, CancellationToken can
             cancellationToken.ThrowIfCancellationRequested();
 
             var memberResult = await forumsClient.Core.GetMember(id, cancellationToken).ConfigureAwait(false);
-            var member = memberResult?.Result?.Data ?? throw new InvalidOperationException($"Member not found with ID: {id}");
+
+            if (memberResult is null || !memberResult.IsSuccess)
+            {
+                throw new InvalidOperationException($"Forums API call failed for member ID: {id} with status: {memberResult?.StatusCode.ToString() ?? "null response"}");
+            }
+
+            var member = memberResult.Result?.Data ?? throw new InvalidOperationException($"Member not found with ID: {id}");
             var user = new IdentityUser { Id = id, UserName = username, Email = email };
             var createUserResult = await userManager.CreateAsync(user).ConfigureAwait(false);